merge queue: checking #513 on main (9596614) - #522
Closed
mergify[bot] wants to merge 31 commits into
Closed
mergify[bot] wants to merge 31 commits into
mergify[bot] wants to merge 31 commits into
Conversation
…ooks/_runner/run.py runs one hook script, passes its stdout, stderr and exit code through unchanged, and appends one metrics row with a classified outcome. Review lane: behavior Safety invariant: A hook run through the runner produces byte-identical stdout and the same exit code as running it directly; a failed metrics write changes neither and adds one stderr line. Effectiveness measurement: Fixture hooks run directly and through the runner give identical stdout bytes and exit codes, and each row carries the expected outcome. Slice rationale: The runner and its outcome rules are one claim, reviewable before any install wiring. Architectural effect: Adds a shared, harness-agnostic hook runner under engine/hooks/_runner/ next to engine/hooks/_markers/. Dormant until installed. Goal: Create the runner, the pure outcome classifier, and tests. Motivation: No record exists today of which hooks fire, stay silent, or crash. Alternative considerations: Editing all 82 entrypoints to import a logging decorator was rejected: it cannot record import errors, syntax errors, or timeouts, and touches every hook. An in-process runpy runner was rejected because a harness-killed or hanging hook would take the recorder down with it. Implementation details: A subprocess wrapper plus a pure classifier in outcome.py. Non-goals: No install.sh, settings, or hook fragment change; no report CLI; no change to any existing hook. Layer: domain Feature state: dormant Files: - engine/hooks/_runner/run.py - engine/hooks/_runner/outcome.py - engine/hooks/_runner/tests/test_outcome.py - engine/hooks/_runner/tests/test_run.py - engine/hooks/_runner/tests/fixtures/ Change types: - engine/hooks/_runner/run.py: create - engine/hooks/_runner/outcome.py: create - engine/hooks/_runner/tests/test_outcome.py: create - engine/hooks/_runner/tests/test_run.py: create - engine/hooks/_runner/tests/fixtures/: create Acceptance criteria: - `python3 -m unittest discover -s engine/hooks/_runner/tests -v` exits 0. - `bash scripts/run_all_tests.sh` exits 0. - `python3 scripts/check_hook_test_coverage.py` exits 0. Exit code: 0 Invoker-Finalize-Id: e5ba51e8-de9e-430f-8672-e0eef3e3bafc
…ine/hooks/_runner/README.md states what the runner records, where the rows go, and the outcome precedence. Review lane: docs Safety invariant: Only engine/hooks/_runner/README.md changes; no code, test, or config file is edited. Effectiveness measurement: Every row field and outcome named in the README appears in run.py and outcome.py, checked by reading both. Slice rationale: Prose in its own commit so the code commit stays one claim. Architectural effect: None; prose only. Goal: Create engine/hooks/_runner/README.md. Motivation: Readers of the hook directory need the row format without reading code. Alternative considerations: Code comments were rejected; the repo forbids new comments. Implementation details: One new Markdown file. Non-goals: No code, test, or config edits. Layer: docs Feature state: dormant Files: - engine/hooks/_runner/README.md Change types: - engine/hooks/_runner/README.md: create Acceptance criteria: - `test -f engine/hooks/_runner/README.md` exits 0. Exit code: 0 Invoker-Finalize-Id: 917f28d4-7b67-447f-bfd1-7a26a20061da
…unner tests, the repo test suite, and the hook coverage gate pass. Review lane: proof Safety invariant: Verification is read-only and does not alter any repository file. Effectiveness measurement: The three commands are the direct measurement. Slice rationale: One focused proof before review. Architectural effect: None; verification only. Goal: Prove pass-through and outcome classification. Motivation: Running the tests is the proof. Alternative considerations: A live-harness run is deferred to step 2, where the runner is installed. Implementation details: Run the three commands. Non-goals: No mutations. Layer: app_regression Feature state: active Acceptance criteria: - Exits 0 only when all pass. Exit code: 0 Invoker-Finalize-Id: e73029a9-e2ea-4d00-8c66-f727763900a1
….t0.a-ae5fdfe43-637dd362
…No ephemeral inter-task handoff files remain in the worktree before the merge gate. Review lane: cleanup Safety invariant: The scrub script only checks for known handoff artifact names and never touches source, tests, or other repository files. Effectiveness measurement: The script exits non-zero if any handoff artifact remains. Slice rationale: Required terminal scrub for every implementation workflow. Architectural effect: None; hygiene only. Goal: Leave the branch free of handoff artifacts. Motivation: Handoff files must not reach the PR. Alternative considerations: Manual cleanup was rejected as non-deterministic. Implementation details: Run scripts/scrub-handoff-artifacts.sh. Layer exception: allowed -- the terminal scrub must run after every task in the workflow, including the docs task. Non-goals: No product edits. Layer: app_regression Feature state: active Acceptance criteria: - `bash scripts/scrub-handoff-artifacts.sh` exits 0. Exit code: 0 Invoker-Finalize-Id: cb09f6f2-66d1-4564-adb3-38e63423dbfa
…af591618b-0e93f775 — Review claim: No ephemeral inter-task handoff files remain in the worktree before the merge gate. Review lane: cleanup Safety invariant: The scrub script only checks for known handoff artifact names and never touches source, tests, or other repository files. Effectiveness measurement: The script exits non-zero if any handoff artifact remains. Slice rationale: Required terminal scrub for every implementation workflow. Architectural effect: None; hygiene only. Goal: Leave the branch free of handoff artifacts. Motivation: Handoff files must not reach the PR. Alternative considerations: Manual cleanup was rejected as non-deterministic. Implementation details: Run scripts/scrub-handoff-artifacts.sh. Layer exception: allowed -- the terminal scrub must run after every task in the workflow, including the docs task. Non-goals: No product edits. Layer: app_regression Feature state: active Acceptance criteria: - `bash scripts/scrub-handoff-artifacts.sh` exits 0.
…n recording fails datetime.UTC exists only on 3.11+, so on CI's Python 3.9 the runner raised after the hook ran and dropped the hook's stdout and exit code. Use datetime.timezone.utc, and catch any failure while classifying or writing the metrics row so the hook's output is still forwarded, with one stderr line naming the error. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G95BG4NxDsW4NA6fcipHrv Change-Id: Ie823ca268e85e83dd57d3b6f1b026946daeb4c99
…nstall.sh wraps every installed catstack hook entry in Claude, Cursor and Codex with the runner, and a second install changes nothing. Review lane: behavior Safety invariant: Every hook registered for Claude, Cursor and Codex goes through the runner; a rerun creates no duplicate entries; non-catstack entries are kept byte-for-byte. Effectiveness measurement: In a temp HOME the three files hold zero unwrapped catstack hook entries after install, and a second install leaves them byte-identical. Slice rationale: All three harnesses in one PR so hooks behave the same everywhere. Architectural effect: Every hook run in every harness now produces a metrics row. Goal: Add wrap_installed.py, link _runner into all three hook roots, and call it last in install.sh. Motivation: The runner is inert until the harness calls it. Alternative considerations: Rewriting the 69 per-hook fragments and the strings embedded in Cursor installers was rejected: it touches every hook, and a new hook added without the wrapper would bypass metrics. A post-install pass covers future hooks automatically. Implementation details: A post-install pass over the three harness config files rewrites matching hook entries to call the runner. Non-goals: No change to run.py or outcome.py, to any hook script, or to the Codex `notify` line in config.toml. Layer: app_bridge Feature state: active Files: - engine/hooks/_runner/wrap_installed.py - engine/hooks/_runner/tests/test_wrap_installed.py - install.sh Change types: - engine/hooks/_runner/wrap_installed.py: create - engine/hooks/_runner/tests/test_wrap_installed.py: create - install.sh: modify Acceptance criteria: - `python3 -m unittest discover -s engine/hooks/_runner/tests -v` exits 0. - `python3 -m unittest tests.test_install -v` exits 0. - `shellcheck install.sh` exits 0. Exit code: 0 Invoker-Finalize-Id: 026f7cd3-16c7-45af-9eb2-8c7ba1483c72
…m: scripts/check_install_effective.py reports every installed catstack hook entry that bypasses the runner. Review lane: policy Safety invariant: The check only reads the three harness config files and reports; it writes nothing. Effectiveness measurement: A test with one wrapped and one unwrapped fixture entry gets exactly one `hook bypasses the metrics runner` line. Slice rationale: The install check is tooling policy, kept apart from the install behavior it checks. Architectural effect: A missed or future hook that bypasses metrics shows up in the install check. Goal: Extend check_install_effective.py with a bypass check. Motivation: Wrapping is only trustworthy if something reports a miss. Alternative considerations: Duplicating the matcher in the check was rejected; it imports match_direct from wrap_installed.py so the two cannot disagree. Implementation details: Import match_direct and print one problem line per unwrapped entry. Non-goals: No install.sh or hook edits. Layer: app_bridge Feature state: active Files: - scripts/check_install_effective.py - tests/test_check_install_effective.py Change types: - scripts/check_install_effective.py: modify - tests/test_check_install_effective.py: create Acceptance criteria: - `python3 -m unittest tests.test_check_install_effective -v` exits 0. Exit code: 0 Invoker-Finalize-Id: 1c706729-4212-4fdc-9c6a-dd8c11051a81
…gine/hooks/_runner/README.md states how install wraps hook entries and how the install check reports a bypass. Review lane: docs Safety invariant: Only engine/hooks/_runner/README.md changes; no code, test, or config file is edited. Effectiveness measurement: The README's entry format and printed messages match wrap_installed.py, checked by reading both. Slice rationale: Prose in its own commit so the code commits stay one claim each. Architectural effect: None; prose only. Goal: Add an Install section to engine/hooks/_runner/README.md. Motivation: Readers need the install shape without reading code. Alternative considerations: Code comments were rejected; the repo forbids new comments. Implementation details: One Markdown section. Non-goals: No code, test, or config edits. Layer: docs Feature state: active Files: - engine/hooks/_runner/README.md Change types: - engine/hooks/_runner/README.md: docs-only Acceptance criteria: - `grep -n "wrap_installed.py" engine/hooks/_runner/README.md` prints at least one line. Exit code: 0 Invoker-Finalize-Id: a272c6e0-1997-4c03-8e14-324d8cf5bdce
…e repo suite, which includes the runner, install, and install-check tests, passes, and install.sh is shellcheck-clean. Review lane: proof Safety invariant: Verification is read-only for the repository; tests write only into temp directories. Effectiveness measurement: The two commands are the direct measurement. Slice rationale: One focused proof before review. Architectural effect: None; verification only. Goal: Prove wrapping is complete and a rerun changes nothing. Motivation: Running the tests is the proof. Alternative considerations: The live claude -p row check needs model access and is run by the parent session after merge. Implementation details: Run the suite and shellcheck. Non-goals: No mutations. Layer: app_regression Feature state: active Acceptance criteria: - Exits 0 only when all pass. Exit code: 127 Invoker-Finalize-Id: 354b2bdb-010c-4742-91ee-4ba090cd0747
…e repo suite, which includes the runner, install, and install-check tests, passes, and install.sh is shellcheck-clean. Review lane: proof Safety invariant: Verification is read-only for the repository; tests write only into temp directories. Effectiveness measurement: The two commands are the direct measurement. Slice rationale: One focused proof before review. Architectural effect: None; verification only. Goal: Prove wrapping is complete and a rerun changes nothing. Motivation: Running the tests is the proof. Alternative considerations: The live claude -p row check needs model access and is run by the parent session after merge. Implementation details: Run the suite and shellcheck. Non-goals: No mutations. Layer: app_regression Feature state: active Acceptance criteria: - Exits 0 only when all pass. Exit code: 0 Invoker-Finalize-Id: publish-approved-fix
…0.t0.a-ab927feb4-e722238b
…No ephemeral inter-task handoff files remain in the worktree before the merge gate. Review lane: cleanup Safety invariant: The scrub script only checks for known handoff artifact names and never touches source, tests, or other repository files. Effectiveness measurement: The script exits non-zero if any handoff artifact remains. Slice rationale: Required terminal scrub for every implementation workflow. Architectural effect: None; hygiene only. Goal: Leave the branch free of handoff artifacts. Motivation: Handoff files must not reach the PR. Alternative considerations: Manual cleanup was rejected as non-deterministic. Implementation details: Run scripts/scrub-handoff-artifacts.sh. Layer exception: allowed -- the terminal scrub must run after every task in the workflow, including the docs task. Non-goals: No product edits. Layer: app_regression Feature state: active Acceptance criteria: - `bash scripts/scrub-handoff-artifacts.sh` exits 0. Exit code: 0 Invoker-Finalize-Id: abcc8dd1-19ae-4cdc-b9a6-8bec5bce3173
…af2175b3f-597cac02 — Review claim: No ephemeral inter-task handoff files remain in the worktree before the merge gate. Review lane: cleanup Safety invariant: The scrub script only checks for known handoff artifact names and never touches source, tests, or other repository files. Effectiveness measurement: The script exits non-zero if any handoff artifact remains. Slice rationale: Required terminal scrub for every implementation workflow. Architectural effect: None; hygiene only. Goal: Leave the branch free of handoff artifacts. Motivation: Handoff files must not reach the PR. Alternative considerations: Manual cleanup was rejected as non-deterministic. Implementation details: Run scripts/scrub-handoff-artifacts.sh. Layer exception: allowed -- the terminal scrub must run after every task in the workflow, including the docs task. Non-goals: No product edits. Layer: app_regression Feature state: active Acceptance criteria: - `bash scripts/scrub-handoff-artifacts.sh` exits 0.
…unner Once wrap_installed.py rewrites an entry to `_runner/run.py --timeout T <hook>/<script>.py`, the only $HOME/.claude/hooks/ path in the command is the runner itself, which exists, so a deleted hook's entry was never pruned. prune_dead_hook_entries.py now also checks the hook script named after the runner. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G95BG4NxDsW4NA6fcipHrv Change-Id: I2d2f61c86f55a52697a191aeffc2049d81247650
…port.py prints one row per registered hook, with `no record` for a hook that never ran, and hook-health tells the agent in all three harnesses about failed hook runs since the last prompt. Review lane: behavior Safety invariant: A registered hook with no rows is "no record", never healthy; the notice never blocks; an unreadable log is unchecked, not clean. Effectiveness measurement: Seeded-log tests assert the table, "no record", the notice text, and the unreadable-log behavior. Slice rationale: Reading the metrics is one claim, apart from producing them in steps 1 and 2. Architectural effect: Hook failures become visible to the agent on the next prompt and to the user on demand. Goal: Create report.py and the hook-health hook with its three-harness install. Motivation: Rows nobody reads detect nothing. Alternative considerations: A Stop-hook notice was rejected because it would interrupt the reply that is already finishing; a SessionStart-only notice was rejected because a crash mid-session would wait for the next session. Implementation details: detect.py is pure (rows in, notice text out); entrypoints read the log from a per-session offset and print the notice in each harness's non-blocking output shape. Non-goals: No change to run.py, outcome.py, or wrap_installed.py; no dashboard or remote upload. Layer: contact_surface Feature state: active Files: - engine/hooks/_runner/report.py - engine/hooks/_runner/tests/test_report.py - engine/hooks/hook-health/detect.py - engine/hooks/hook-health/claude_prompt_submit.py - engine/hooks/hook-health/cursor_before_submit.py - engine/hooks/hook-health/codex_prompt_submit.py - engine/hooks/hook-health/claude.hook.json - engine/hooks/hook-health/codex.hook.json - engine/hooks/hook-health/install_claude_hook.py - engine/hooks/hook-health/install_cursor_hook.py - engine/hooks/hook-health/install_codex_hook.py - engine/hooks/hook-health/tests/test_detect.py - engine/hooks/hook-health/tests/test_hooks.py - install.sh Change types: - engine/hooks/_runner/report.py: create - engine/hooks/_runner/tests/test_report.py: create - engine/hooks/hook-health/detect.py: create - engine/hooks/hook-health/claude_prompt_submit.py: create - engine/hooks/hook-health/cursor_before_submit.py: create - engine/hooks/hook-health/codex_prompt_submit.py: create - engine/hooks/hook-health/claude.hook.json: create - engine/hooks/hook-health/codex.hook.json: create - engine/hooks/hook-health/install_claude_hook.py: create - engine/hooks/hook-health/install_cursor_hook.py: create - engine/hooks/hook-health/install_codex_hook.py: create - engine/hooks/hook-health/tests/test_detect.py: create - engine/hooks/hook-health/tests/test_hooks.py: create - install.sh: modify Acceptance criteria: - `python3 -m unittest discover -s engine/hooks/_runner/tests -v` exits 0. - `python3 -m unittest discover -s engine/hooks/hook-health/tests -v` exits 0. - `python3 scripts/check_hook_test_coverage.py` exits 0. - `bash scripts/run_all_tests.sh` exits 0. Exit code: 0 Invoker-Finalize-Id: e5a2c7d4-4239-4d64-aa80-1efc40d7fbe2
…m: engine/hooks/hook-health/README.md and a Report section in engine/hooks/_runner/README.md state what the table and the notice show. Review lane: docs Safety invariant: Only the two Markdown files change; no code, test, or config file is edited. Effectiveness measurement: Every column and message named in the prose appears in report.py or detect.py, checked by reading both. Slice rationale: Prose in its own commit so the code commit stays one claim. Architectural effect: None; prose only. Goal: Create engine/hooks/hook-health/README.md and add a Report section to engine/hooks/_runner/README.md. Motivation: Readers need the table and notice format without reading code. Alternative considerations: Code comments were rejected; the repo forbids new comments. Implementation details: Two Markdown edits. Non-goals: No code, test, or config edits. Layer: docs Feature state: active Files: - engine/hooks/hook-health/README.md - engine/hooks/_runner/README.md Change types: - engine/hooks/hook-health/README.md: create - engine/hooks/_runner/README.md: docs-only Acceptance criteria: - `test -f engine/hooks/hook-health/README.md` exits 0. Exit code: 0 Invoker-Finalize-Id: 5512a433-370f-4af9-98ce-321f2188fc66
… The repo suite, which includes the runner and hook-health tests, and the hook coverage gate pass. Review lane: proof Safety invariant: Verification is read-only and does not alter any repository file. Effectiveness measurement: The two commands are the direct measurement. Slice rationale: One focused proof before review. Architectural effect: None; verification only. Goal: Prove the report and notice behavior. Motivation: Running the tests is the proof. Alternative considerations: The full suite is included because install.sh changes. Implementation details: Run the suite and the coverage gate. Non-goals: No mutations. Layer: app_regression Feature state: active Acceptance criteria: - Exits 0 only when all pass. Exit code: 0 Invoker-Finalize-Id: 260483f4-93d9-470a-8d2a-9e4971a54b18
…ice/g0.t1.a-a6d820dc7-e8e99f8b
…No ephemeral inter-task handoff files remain in the worktree before the merge gate. Review lane: cleanup Safety invariant: The scrub script only checks for known handoff artifact names and never touches source, tests, or other repository files. Effectiveness measurement: The script exits non-zero if any handoff artifact remains. Slice rationale: Required terminal scrub for every implementation workflow. Architectural effect: None; hygiene only. Goal: Leave the branch free of handoff artifacts. Motivation: Handoff files must not reach the PR. Alternative considerations: Manual cleanup was rejected as non-deterministic. Implementation details: Run scripts/scrub-handoff-artifacts.sh. Layer exception: allowed -- the terminal scrub must run after every task in the workflow, including the docs task. Non-goals: No product edits. Layer: app_regression Feature state: active Acceptance criteria: - `bash scripts/scrub-handoff-artifacts.sh` exits 0. Exit code: 0 Invoker-Finalize-Id: 65a5143c-73b6-48fa-b975-b68b58cdfc3b
…aa09fa676-478048c6 — Review claim: No ephemeral inter-task handoff files remain in the worktree before the merge gate. Review lane: cleanup Safety invariant: The scrub script only checks for known handoff artifact names and never touches source, tests, or other repository files. Effectiveness measurement: The script exits non-zero if any handoff artifact remains. Slice rationale: Required terminal scrub for every implementation workflow. Architectural effect: None; hygiene only. Goal: Leave the branch free of handoff artifacts. Motivation: Handoff files must not reach the PR. Alternative considerations: Manual cleanup was rejected as non-deterministic. Implementation details: Run scripts/scrub-handoff-artifacts.sh. Layer exception: allowed -- the terminal scrub must run after every task in the workflow, including the docs task. Non-goals: No product edits. Layer: app_regression Feature state: active Acceptance criteria: - `bash scripts/scrub-handoff-artifacts.sh` exits 0.
Change-Id: Ib8713304c6f26e1a76ee79b4af09589c7a501bee # Conflicts: # engine/hooks/_runner/README.md
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#513 is queued for merge on branch main (9596614).
This pull request has been created by Mergify to check the mergeability of #513.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
admin-bypassfor merge:check-success = lintcheck-success = testRequired conditions to stay in the queue:
-draftbase=mainlabel=admin-bypass