fix(flow-chat): route permission requests to a single owner - #2595
Merged
bobleer merged 1 commit intoAug 28, 2026
Merged
Conversation
BTW and review sessions render outside the main flow-chat container, so a direct permission request could block the child runtime without exposing any way to answer it in the side panel. Render the shared permission mailbox in BtwSessionPanel and separate broad transcript routing from actionable ownership. Delegated subagent requests remain owned by the parent Task surface, while direct review-child requests stay with the child surface. This avoids duplicate permission panels without inheriting the parent's permission mode. Add routing and hook regression coverage for direct and delegated requests, including the one-owner active batch behavior.
guantw
added a commit
to guantw/BitFun
that referenced
this pull request
Aug 28, 2026
Adapt GCWing#2595 to the Explore composer architecture. The primary composer handles only requests owned by the primary session, while embedded BTW and review panels expose direct child-session requests through the shared approval band. Delegated requests remain actionable only from the parent surface.
guantw
added a commit
to guantw/BitFun
that referenced
this pull request
Aug 28, 2026
Adapt GCWing#2595 to the Explore composer architecture. The primary composer handles only requests owned by the primary session, while embedded BTW and review panels expose direct child-session requests through the shared approval band. Delegated requests remain actionable only from the parent surface. Repair stale design-system test mocks inherited from the latest Explore base so the full frontend suite can exercise the migrated SSH and Appearance dialogs.
guantw
added a commit
to guantw/BitFun
that referenced
this pull request
Aug 28, 2026
Adapt GCWing#2595 to the Explore composer architecture. The primary composer handles only requests owned by the primary session, while embedded BTW and review panels expose direct child-session requests through the shared approval band. Delegated requests remain actionable only from the parent surface. Repair stale design-system test mocks and normalize a cross-platform stylesheet fixture inherited from the latest Explore base so the full frontend suite passes on Linux and Windows checkouts.
1688mengdie
pushed a commit
to BitFun-SIG/taiji-plugin-library
that referenced
this pull request
Aug 29, 2026
上游 2 提交（PR GCWing#2595 权限请求单 owner 路由）: - 4177686 fix(flow-chat): route permission requests to a single owner - 32f2427 Merge pull request GCWing#2595 交集 3 文件 auto-merge 干净，逐文件归因（无文本冲突）: - BtwSessionPanel.tsx: 原则③双方并存（上游权限信箱投影嵌入 BTW 面板 / 本地历史自动加载放宽+chat-full-width+失败重试），锚点互不重叠 - ModernFlowChatContainer.tsx: 原则④上游 ownedRequests/ownedActiveBatch 收窄口径采上游 + 本地 headerLeftActionsContent（R-GC-24）并存 - usePermissionRequests.test.tsx: 原则③双方并存（上游 owned 语义断言×2 + 本地 getAvailableModes mock） 验证门: cargo check -p bitfun-core --lib / --features agent-runtime / --features product-full / -p bitfun-transport --jobs 4 + cargo metadata --locked 探针（记录见 sync-record-20260829-四区.md） Cargo.lock 工作树遗留为所有者未裁决产物，现状保留未动
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ported from GitCode PR #75.
Type and Areas
Type: regression fix
Areas: Web UI, FlowChat permission routing, BTW/review sessions
Motivation / Impact
BTW and review sessions render outside
ModernFlowChatContainer. A direct permission request from one of these child sessions could therefore block its runtime without exposing a way to answer it in the side panel. Delegated requests also need one actionable owner to avoid duplicate permission panels.This change lets direct review-child requests stay actionable on the child surface while delegated subagent requests remain owned by the parent Task surface.
Verification
pnpm --dir src/web-ui run test:run src/flow_chat/components/modern/permissionRequestRouting.test.ts src/flow_chat/components/modern/usePermissionRequests.test.tsx— 2 files, 17 tests passed.pnpm --dir src/web-ui run lint— passed.pnpm run type-check:web— passed.git diff --check— passed.Remote scenarios: no live remote scenario was exercised. The owner-selection behavior is covered at unit/hook level; Remote Control and Peer Device Mode remain pending manual integration checks. Remote Workspace and Detached Dispatch are not directly affected by this UI-only change.
Reviewer Notes
git range-diffconfirms this is patch-equivalent to GitCode PR Third-party API incompatibility #75 on top of the current GitHubmain.Checklist