Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
minleejae
force-pushed
the
fix/alter-comment-identifiers
branch
from
September 22, 2026 09:38
d0d80a2 to
b127d10
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALTER TABLE t MODIFY COLUMN comment TEXTpreviously entered the column-comment grammar branch, while DROP/RENAME/CHANGE could reject the unquoted name. Require the complete COMMENT-literal lookahead and acceptcommentin the shared ALTER identifier helper.The existing column-definition/name APIs remain usable for inspecting and editing these actions. Includes a usage example and regressions for ADD/MODIFY/CHANGE/DROP/RENAME, parsed AST mutation, statement deparsing and reparsing, with default and MYSQL configurations.
Validation: full Gradle
checkon Java 17 (including grammar ambiguity, formatting, Checkstyle, PMD and tests); six valid DDL fixtures executed both before and after parser rendering on MySQL 8.4, with catalog checks for resulting names/types. The grammar fix is shared; no dialect restriction is added to previously supported syntax.