Skip to content

fix(cli): render stack-squash validation errors via clap#1671

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/render-stack-squash-val-errors-via-clap--86663735
Jun 25, 2026
Merged

fix(cli): render stack-squash validation errors via clap#1671
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/render-stack-squash-val-errors-via-clap--86663735

Conversation

@JulianMaurin

@JulianMaurin JulianMaurin commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Route stack squash argument validation through clap::Error
(ValueValidation) so failures render with the usage line and the
standard exit code, like other parse errors, instead of a bare
eprintln! + exit(2).

Also correct the --debug dispatch comment: the flag is consumed by
init_tracing() at startup, not by command impls.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@JulianMaurin JulianMaurin mentioned this pull request Jun 22, 2026
Merged
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 22, 2026 09:10 Failure
This was referenced Jun 22, 2026
Merged
Merged
This was referenced Jun 22, 2026
Merged
Merged
Merged
Merged
Merged
Merged
@JulianMaurin

JulianMaurin commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 fix(cli): render stack-squash validation errors via clap #1671 👈
2 feat(install): print how to enable shell completions #1675
3 docs: make the README a full CLI-contract reference #1676
4 fix(queue): treat a not-queued PR as a normal state, not an API error #1678
5 fix(config): surface an invalid simulate config as a config error #1679
6 fix(ci): return a runtime error when scopes --write fails #1680
7 fix(stack): exit not-found when checkout finds no stack #1681
8 feat(cli): support the git-style help subcommand #1682
9 docs(cli): correct stack reorder and scopes-send help text #1683

@JulianMaurin JulianMaurin mentioned this pull request Jun 22, 2026
Merged
@mergify

mergify Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 6 merge protections satisfied — ready to merge.

Show 6 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/render-stack-squash-val-errors-via-clap--86663735 branch from 3a3ab58 to c756dce Compare June 22, 2026 09:15
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/rewrite-agents-md-rust-workspace--f56ea725 branch from 6825213 to b085db1 Compare June 22, 2026 09:15
@JulianMaurin

JulianMaurin commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Revision history

# Type Changes Reason Date
1 initial 3a3ab58 2026-06-22 09:15 UTC
2 rebase 3a3ab58 → c756dce (rebase only) 2026-06-22 09:15 UTC
3 rebase c756dce → c41b366 (rebase only) 2026-06-22 13:00 UTC
4 rebase c41b366 → bd031e8 (rebase only) 2026-06-23 07:41 UTC
5 rebase bd031e8 → d443840 (rebase only) 2026-06-23 09:11 UTC
6 rebase d443840 → bf0cbee (rebase only) 2026-06-23 12:10 UTC
7 rebase bf0cbee → cbbb1dd (rebase only) 2026-06-23 12:38 UTC
8 rebase cbbb1dd → 1fecbbb (rebase only) 2026-06-23 13:08 UTC

@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 22, 2026 09:16 Failure
@mergify mergify Bot requested a review from a team June 22, 2026 09:25
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/render-stack-squash-val-errors-via-clap--86663735 branch from c756dce to c41b366 Compare June 22, 2026 13:00
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/rewrite-agents-md-rust-workspace--f56ea725 branch from b085db1 to 9bf2df1 Compare June 22, 2026 13:00
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 22, 2026 13:01 Failure
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/render-stack-squash-val-errors-via-clap--86663735 branch from c41b366 to bd031e8 Compare June 23, 2026 07:41
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/rewrite-agents-md-rust-workspace--f56ea725 branch from 9bf2df1 to 053fa29 Compare June 23, 2026 07:41
@mergify mergify Bot dismissed kozlek’s stale review June 23, 2026 13:08

Pull request has been modified.

@mergify mergify Bot deployed to Mergify Merge Protections June 23, 2026 13:08 Active
@mergify mergify Bot requested a review from a team June 23, 2026 13:14
@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Required conditions to enter a queue
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • deployment-success = Mergify Merge Protections [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule default]:
      • base=main
      • label!=manual merge
      • all of [🛡 Merge Protections rule Enforce conventional commit]:
        • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:
      • all of [🛡 Merge Protections rule 👀 Review Requirements]:
        • any of:
          • #approved-reviews-by>=2
          • author = dependabot[bot]
          • author = mergify-ci-bot
          • author = renovate[bot]
      • all of [🛡 Merge Protections rule 📕 PR description]:
        • body ~= (?ms:.{48,})
      • all of [🛡 Merge Protections rule 🔎 Reviews]:
        • #changes-requested-reviews-by = 0
        • #review-requested = 0
        • #review-threads-unresolved = 0
      • all of [🛡 Merge Protections rule 🤖 Continuous Integration]:
        • all of:
          • check-success=ci-gate
    • all of [📌 queue conditions of queue rule dependencies]:
      • any of:
        • author = dependabot[bot]
        • author = renovate[bot]
      • base=main
      • label!=manual merge
      • all of [🛡 Merge Protections rule Enforce conventional commit]:
        • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:
      • all of [🛡 Merge Protections rule 👀 Review Requirements]:
        • any of:
          • #approved-reviews-by>=2
          • author = dependabot[bot]
          • author = mergify-ci-bot
          • author = renovate[bot]
      • all of [🛡 Merge Protections rule 📕 PR description]:
        • body ~= (?ms:.{48,})
      • all of [🛡 Merge Protections rule 🔎 Reviews]:
        • #changes-requested-reviews-by = 0
        • #review-requested = 0
        • #review-threads-unresolved = 0
      • all of [🛡 Merge Protections rule 🤖 Continuous Integration]:
        • all of:
          • check-success=ci-gate

@mergify mergify Bot requested a review from a team June 23, 2026 13:16
This was referenced Jun 23, 2026
Merged
Merged
Merged
Merged
Open
Open
@mergify mergify Bot added the queued label Jun 23, 2026
@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 8 minutes 29 seconds in the queue, including 8 minutes 7 seconds running CI.

Waiting for
  • check-success=ci-gate
All conditions

Reason

The merge conditions cannot be satisfied due to failing checks

  • ci-gate

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

This was referenced Jun 23, 2026
Closed
Closed
@mergify mergify Bot added dequeued and removed queued labels Jun 23, 2026
@JulianMaurin

JulianMaurin commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify

mergify Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 7 minutes 19 seconds in the queue, including 6 minutes 54 seconds running CI.

Required conditions to merge

@mergify mergify Bot added queued and removed dequeued labels Jun 25, 2026
This was referenced Jun 25, 2026
Closed
Closed
@mergify mergify Bot merged commit b8a88ab into main Jun 25, 2026
22 of 42 checks passed
@mergify mergify Bot deleted the devs/JulianMaurin/feat/rust-cli-excellence/render-stack-squash-val-errors-via-clap--86663735 branch June 25, 2026 05:47
@mergify mergify Bot removed the queued label Jun 25, 2026
@mergify mergify Bot mentioned this pull request Jun 25, 2026
Closed
38 tasks
mergify Bot pushed a commit that referenced this pull request Jun 25, 2026
@JulianMaurin
feat(install): print how to enable shell completions (#1675)
c6bfedc 
After dropping the binary, print the exact command to enable tab
completion for the detected shell ($SHELL): bash, zsh, and fish each
get a ready-to-paste line; any other shell is pointed at `mergify
completions`. The installer writes nothing into the user's shell dirs.

A curl|sh installer that ships a single binary leaves shell config to
the user, as rustup and starship do; writing completion files from it
is both surprising and unreliable — ~/.zfunc is off zsh's $fpath by
default. Man-page generation stays available via the binary for real
packaging.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Depends-On: #1671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jd jd jd approved these changes
@kozlek kozlek kozlek approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JulianMaurin @jd @kozlek