Skip to content

fix(queue): treat a not-queued PR as a normal state, not an API error#1678

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/treat-queued-pr-normal-state-api-error--6f7ca3cf
Jun 25, 2026
Merged

fix(queue): treat a not-queued PR as a normal state, not an API error#1678
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/treat-queued-pr-normal-state-api-error--6f7ca3cf

Conversation

@JulianMaurin

@JulianMaurin JulianMaurin commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

queue show mapped a PR that isn't in the merge queue to exit 6
(Mergify API error) with empty stdout — so --json consumers got
nothing parseable for the most common case, and scripts saw an
API-failure code for a routine state.

Report it on stdout and exit 0 instead: a {"number": N, "queued": false} document under --json, the PR #N is not in the merge queue line in human mode.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@JulianMaurin JulianMaurin mentioned this pull request Jun 23, 2026
Merged
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 23, 2026 18:28 Failure
This was referenced Jun 23, 2026
Merged
Merged
@JulianMaurin

JulianMaurin commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 fix(queue): treat a not-queued PR as a normal state, not an API error #1678 👈
2 fix(config): surface an invalid simulate config as a config error #1679
3 fix(ci): return a runtime error when scopes --write fails #1680
4 fix(stack): exit not-found when checkout finds no stack #1681
5 feat(cli): support the git-style help subcommand #1682
6 docs(cli): correct stack reorder and scopes-send help text #1683

This was referenced Jun 23, 2026
Merged
Merged
Merged
Open
Open
@JulianMaurin JulianMaurin marked this pull request as ready for review June 23, 2026 18:29
@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 6 merge protections satisfied — ready to merge.

Show 6 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/treat-queued-pr-normal-state-api-error--6f7ca3cf branch from 9ef5865 to 62bec7d Compare June 25, 2026 07:49
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/make-readme-full-cli-contract-ref--4677f612 branch from 16f2d20 to 4e28508 Compare June 25, 2026 07:49
@JulianMaurin

JulianMaurin commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Revision history

# Type Changes Reason Date
1 initial 9ef5865 2026-06-25 07:49 UTC
2 rebase 9ef5865 → 62bec7d (rebase only) 2026-06-25 07:49 UTC
3 rebase 62bec7d → 0dd17d0 (rebase only) 2026-06-25 07:56 UTC
4 rebase 0dd17d0 → f2561e6 (rebase only) 2026-06-25 08:51 UTC

@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 25, 2026 07:49 Failure
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/make-readme-full-cli-contract-ref--4677f612 branch from 4e28508 to e9c1676 Compare June 25, 2026 07:56
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/treat-queued-pr-normal-state-api-error--6f7ca3cf branch from 62bec7d to 0dd17d0 Compare June 25, 2026 07:56
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 25, 2026 07:56 Failure
@mergify mergify Bot requested a review from a team June 25, 2026 08:03
Base automatically changed from devs/JulianMaurin/feat/rust-cli-excellence/make-readme-full-cli-contract-ref--4677f612 to main June 25, 2026 08:38
@JulianMaurin @claude
fix(queue): treat a not-queued PR as a normal state, not an API error
f2561e6 
`queue show` mapped a PR that isn't in the merge queue to exit 6
(Mergify API error) with empty stdout — so `--json` consumers got
nothing parseable for the most common case, and scripts saw an
API-failure code for a routine state.

Report it on stdout and exit 0 instead: a `{"number": N, "queued":
false}` document under `--json`, the `PR #N is not in the merge
queue` line in human mode.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I6f7ca3cf3cffb83ba129a1c48d2aab218dabd989
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/treat-queued-pr-normal-state-api-error--6f7ca3cf branch from 0dd17d0 to f2561e6 Compare June 25, 2026 08:51
@mergify mergify Bot deployed to Mergify Merge Protections June 25, 2026 08:51 Active
@mergify mergify Bot requested a review from a team June 25, 2026 09:09
@mergify

mergify Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-06-25 09:11 UTC · Rule: default · triggered by merge protections
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-06-25 09:12 UTC · at f2561e62cf0954b33f7f85ce1e2be7ade493ca32 · squash

This pull request spent 33 seconds in the queue, including 5 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Jun 25, 2026
@mergify mergify Bot merged commit 71dd92c into main Jun 25, 2026
22 checks passed
@mergify mergify Bot deleted the devs/JulianMaurin/feat/rust-cli-excellence/treat-queued-pr-normal-state-api-error--6f7ca3cf branch June 25, 2026 09:12
@mergify mergify Bot removed the queued label Jun 25, 2026
@mergify mergify Bot mentioned this pull request Jun 25, 2026
Closed
38 tasks
mergify Bot pushed a commit that referenced this pull request Jun 25, 2026
@JulianMaurin
fix(config): surface an invalid simulate config as a config error (#1679
da360b4 
)

A schema-invalid config uploaded by `config simulate` came back as
the simulator's HTTP 422 and was reported as a Mergify API failure
(exit 6) — even though the same fixture fails `config validate`
client-side with exit 8. The drift meant a local-config problem
looked like a service problem to scripts.

Add `HttpClient::post_classifying`, which lets a caller remap a
terminal status before the default flavor mapping, and use it in
`simulate` to map the simulator's 422 to a configuration error
(exit 8).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Depends-On: #1678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sileht sileht sileht approved these changes
@kozlek kozlek kozlek approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JulianMaurin @sileht @kozlek