Skip to content

[https://nvbugs/5961814][unwaive] Unwaive DeepSeek V3 Lite NVFP4 test - #17819

Merged
peaceh-nv merged 1 commit into
NVIDIA:mainfrom
peaceh-nv:peaceh/verify-rtx6000d-deepseekv3lite-20260817
Aug 25, 2026
Merged

[https://nvbugs/5961814][unwaive] Unwaive DeepSeek V3 Lite NVFP4 test#17819
peaceh-nv merged 1 commit into
NVIDIA:mainfrom
peaceh-nv:peaceh/verify-rtx6000d-deepseekv3lite-20260817

Conversation

@peaceh-nv

@peaceh-nv peaceh-nv commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Unwaive two tests on RTX6kD due to machine config issue which is fixed now.

Dev Engineer Review

  • Removed two RTXPro6000D DeepSeekV3Lite NVFP4 entries from tests/integration/test_lists/waives.txt.
  • The waiver scope matches the fixed machine configuration issue.
  • No code, API, performance, or error-handling changes were made.
  • The waiver-file format remains valid.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Removed two skipped RTXPro6000D DeepSeekV3Lite NVFP4 accuracy test entries.
  • No test-db/ or qa/ files were modified.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 26a64cd3-263a-4201-8518-a0a443c9fddc

📥 Commits

Reviewing files that changed from the base of the PR and between 33df8c1 and bd832de.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The waiver list removes two skipped RTXPro6000D DeepSeekV3Lite NVFP4 accuracy-test entries for 4-GPU EP4 configurations.

Changes

Cohort / File(s) Summary
Accuracy waiver updates
tests/integration/test_lists/waives.txt
Removes waiver entries for MTP-disabled and MTP-enabled configurations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bd832

This change re-enables two previously waived integration tests after the machine configuration issue was fixed; no actionable merge-blocking risk remains.

Suggested reviewers: mzweilz

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the change and cause but omits the required Description, Test Coverage, and PR Checklist sections. Add the required template sections and document the relevant test coverage and checklist review.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the NVBugs issue, change type, and removal of waivers for the DeepSeek V3 Lite NVFP4 tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@peaceh-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66736 [ run ] triggered by Bot. Commit: 362fd0b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66736 [ run ] completed with state SUCCESS. Commit: 362fd0b
/LLM/main/L0_MergeRequest_PR pipeline #54343 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@peaceh-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66932 [ run ] triggered by Bot. Commit: 362fd0b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66932 [ run ] completed with state FAILURE. Commit: 362fd0b
/LLM/main/L0_MergeRequest_PR pipeline #54484 (Partly Tested) completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@peaceh-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67608 [ run ] triggered by Bot. Commit: 362fd0b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67608 [ run ] completed with state SUCCESS. Commit: 362fd0b
/LLM/main/L0_MergeRequest_PR pipeline #55096 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@peaceh-nv
peaceh-nv force-pushed the peaceh/verify-rtx6000d-deepseekv3lite-20260817 branch from 362fd0b to 647b4ae Compare August 20, 2026 07:16
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@peaceh-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67744 [ run ] triggered by Bot. Commit: 647b4ae Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67744 [ run ] completed with state FAILURE. Commit: 647b4ae
/LLM/main/L0_MergeRequest_PR pipeline #55223 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

… RTX 6000D

Signed-off-by: peaceh-nv <103117813+peaceh-nv@users.noreply.github.com>
@peaceh-nv
peaceh-nv force-pushed the peaceh/verify-rtx6000d-deepseekv3lite-20260817 branch from 647b4ae to bd832de Compare August 24, 2026 01:54
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@peaceh-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68635 [ run ] triggered by Bot. Commit: bd832de Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68635 [ run ] completed with state FAILURE. Commit: bd832de
/LLM/main/L0_MergeRequest_PR pipeline #56039 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@peaceh-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68779 [ run ] triggered by Bot. Commit: bd832de Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68779 [ run ] completed with state SUCCESS. Commit: bd832de
/LLM/main/L0_MergeRequest_PR pipeline #56175 completed with status: 'SUCCESS'

CI Report

Link to invocation

@peaceh-nv
peaceh-nv merged commit eb71774 into NVIDIA:main Aug 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants