Stop CoreData from keeping a stale source author_id after TES - #21
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop CoreData from keeping a stale source author_id after TES#21Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:19
xai-org#128 runs InNetwork after CoreData so TES can fill author_id. CoreData only wrote author_id when the source field was 0. Phoenix and Thunder ship a nonzero id. TES ran and was discarded. InNetwork stamped the source id. A followed TES author then hit TimelineHomeRecommendations. NSFW HP / gore / card Recs-drop; the same labels are interstitial on TimelineHome. TES author now overwrites a nonzero source id. TES miss still keeps source. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/tes-author-overwrite-in-network-a4ef
branch
from
September 7, 2026 04:22
daaba32 to
172c429
Compare
Owner
Author
|
Wrong base (fork PR). Ship vehicle is upstream xai-org#131. Per submit law: never PR Pitchfork-and-Torch/x-algorithm. Do not merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conflict resolution
This fork branch was rebased onto latest
xai-org/x-algorithmmain. Fork-only commits (#1, #6–#11) were dropped.Canonical PR: xai-org#131
That PR is MERGEABLE, 1 file, 1 commit.
home-mixer/candidate_hydrators/core_data_candidate_hydrator.rsauthor_idThis fork PR will look dirty against Pitchfork
mainbecause the head is now upstreammainplus the one TES-author commit. Use xai-org#131.