Stop treating gizmoduck age 0 as a confirmed underage viewer - #23
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop treating gizmoduck age 0 as a confirmed underage viewer#23Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
SensitiveViewerUnderageDropRule used Known(0) as underage, so a missing birthday sentinel hard-dropped all sensitive media worldwide. Classify non-positive age like a missing birthday (NotStated if the user exists, Unknown otherwise). Move BidirectionalFollowHydrator after CoreData and skip author_id=0 so unhydrated rows are not stamped false mutual-follow. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/sensitive-viewer-age-zero-15a8
branch
from
September 7, 2026 04:24
b0935fd to
9d4e5e5
Compare
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:31
Owner
Author
|
Wrong base (fork PR). Ship vehicle is upstream xai-org#133. Per submit law: never PR Pitchfork-and-Torch/x-algorithm. Do not merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto latest xai-org/x-algorithm main. Fork-only commits dropped.
The mergeable upstream PR is xai-org#133 (
mergeable: true, 1 commit, 5 files).This fork PR still targets fork
main, so GitHub will show a large dirty diff here. Use xai-org#133 for review/merge.Preserved logic
age_in_years Some(0)is missing birthday, notKnown(0)underage. Mapage > 0→ Known; existing user without usable age → NotStated; else Unknown. Age gates stay for logged-out, Known(1..17), and NotStated in NSFW_GATING_COUNTRIES.author_id=0. InNetwork order from Stop For You from stamping OON before TES fills author_id xai-org/x-algorithm#128 unchanged.Age-gate tests live in upstream
visibility-filtering/rules/tweet_rules.rs(this dump previously usednsfw_age_gating.rs).