Skip to content

🛡️ Sentinel: [MEDIUM] Prevent error detail leakage in users API #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pmaster-dev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [MEDIUM] Prevent error detail leakage in users API #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c6e3cd
🛡️ Sentinel: Fix error detail leakage in users API
google-labs-jules[bot] Sep 9, 2026
7659406
🛡️ Sentinel: Fix error detail leakage in users API
google-labs-jules[bot] Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions server/api/v1/users.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ router.get('/', auth0Service.checkJwt, auth0Service.checkPermissions(['read:user
return res.json(sanitizedUsers);
} catch (error: any) {
console.error('Error fetching users:', error);
return res.status(500).json({ message: 'Error fetching users', error: error.message });
// Do not leak raw internal error message details to clients
return res.status(500).json({ message: 'Error fetching users' });
}
});

Expand Down Expand Up @@ -59,7 +60,8 @@ router.get('/:id', auth0Service.checkJwt, async (req: Request, res: Response) =>
return res.json(userWithoutPassword);
} catch (error: any) {
console.error('Error fetching user:', error);
return res.status(500).json({ message: 'Error fetching user', error: error.message });
// Do not leak raw internal error message details to clients
return res.status(500).json({ message: 'Error fetching user' });
}
});

Expand Down Expand Up @@ -116,7 +118,8 @@ router.post('/', auth0Service.checkJwt, auth0Service.checkPermissions(['create:u
});
} catch (error: any) {
console.error('Error creating user:', error);
return res.status(500).json({ message: 'Error creating user', error: error.message });
// Do not leak raw internal error message details to clients
return res.status(500).json({ message: 'Error creating user' });
}
});

Expand Down Expand Up @@ -171,7 +174,8 @@ router.put('/:id', auth0Service.checkJwt, async (req: Request, res: Response) =>
return res.json(userWithoutPassword);
} catch (error: any) {
console.error('Error updating user:', error);
return res.status(500).json({ message: 'Error updating user', error: error.message });
// Do not leak raw internal error message details to clients
return res.status(500).json({ message: 'Error updating user' });
}
});

Expand Down Expand Up @@ -210,7 +214,8 @@ router.delete('/:id', auth0Service.checkJwt, auth0Service.checkPermissions(['del
return res.status(204).end();
} catch (error: any) {
console.error('Error deleting user:', error);
return res.status(500).json({ message: 'Error deleting user', error: error.message });
// Do not leak raw internal error message details to clients
return res.status(500).json({ message: 'Error deleting user' });
}
});

Expand Down Expand Up @@ -255,7 +260,8 @@ router.get('/:id/permissions', auth0Service.checkJwt, async (req: Request, res:
return res.json({ permissions: permissionsResult.permissions || [] });
} catch (error: any) {
console.error('Error fetching user permissions:', error);
return res.status(500).json({ message: 'Error fetching user permissions', error: error.message });
// Do not leak raw internal error message details to clients
return res.status(500).json({ message: 'Error fetching user permissions' });
}
});

Expand Down Expand Up @@ -300,7 +306,8 @@ router.get('/:id/roles', auth0Service.checkJwt, async (req: Request, res: Respon
return res.json({ roles: rolesResult.roles || [] });
} catch (error: any) {
console.error('Error fetching user roles:', error);
return res.status(500).json({ message: 'Error fetching user roles', error: error.message });
// Do not leak raw internal error message details to clients
return res.status(500).json({ message: 'Error fetching user roles' });
}
});

Expand Down
Loading