Conversation
* Add "failing examples" to CI * Remove incorrect example * Make failure check more narrow * Use more structured input for should_fail (more readable)
Contributor
Author
|
Needing your support to solve the conflict in the CI, @thbar |
TuThoThai
added
the
CI & Backport
Contributor
Need to create a sister branch for that (cannot be done in UI mode), will keep you posted. |
Contributor
|
@TuThoThai closing in favour of #1076. But we need to rework the parent check for backport PRs (I think the current case is the first case of a conflict-arising PR, case which has not been met before), because it's blocking for now there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1074 contains the below changes:
This PR is the backport of its single commit into
v2.1-wip