Conversation
* Add "failing examples" to CI * Remove incorrect example * Make failure check more narrow * Use more structured input for should_fail (more readable)
Contributor
Author
|
Chicken and egg issue: backport PRs should be excluded from the parent check. I'll come back to that later @TuThoThai |
thbar
added a commit
that referenced
this pull request
Sep 19, 2026
Before: only the target branch was compared to its parent, so backport PRs were blocked too (see #1076). After: commits brought in by the PR itself are included in the comparison.
Contributor
Author
|
Backport branches were not supported correctly yet by the parent check. I'm fixing it here: (but the real-test will be once #1077 is merged in, to update here and verify if things go green). cc @TuThoThai |
TuThoThai
added
the
CI & Backport
Contributor
|
Needs to be rechecked once we merge #1083 to ensure there is no conflict in the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces:
Reason: the backport in #1075 triggers a git conflict which cannot be solved via web UI.
Copy pasting @TuThoThai description:
Current PR contains the below changes:
This PR is the backport of its single commit into
v2.1-wip