fix(did): rename did:pkh test fixtures to remove Windows-invalid colons - #156
fix(did): rename did:pkh test fixtures to remove Windows-invalid colons#156ygd58 wants to merge 1 commit into
Conversation
Fixes agentcommercekit#145 The three JSON fixtures under test-fixtures/did-pkh/ used the literal did:pkh:... URI (colons included) as their filename. ':' is a reserved character on Windows/NTFS, so these files failed to check out correctly on Windows, breaking pkh-did-resolver.test.ts for Windows contributors and CI runners. Renamed the three fixtures to replace ':' with '_' and updated the corresponding static imports in pkh-did-resolver.test.ts. File contents are unchanged - confirmed via git mv (tracked as renames) and by rerunning the test, which still resolves all four did:pkh test vectors correctly. Changeset added (patch, @agentcommercekit/did). AI usage disclosure: this fix was developed with Claude (Anthropic) assistance - identifying the fixture files as the root cause, renaming them, updating the import paths, and verifying locally. I reviewed and understand the change: three files were renamed (git mv, content untouched) and three import statements in one test file were updated to match the new filenames.
|
Warning Review limit reached
Next review available in: 51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Fixes #145
The three JSON fixtures under
test-fixtures/did-pkh/used the literaldid:pkh:...URI (colons included) as their filename.:is a reserved character on Windows/NTFS, so these files failed to check out correctly on Windows, breakingpkh-did-resolver.test.tsfor Windows contributors and CI runners.Fix: renamed the three fixtures to replace
:with_(e.g.did_pkh_eip155_1_0x....json) and updated the corresponding static imports inpkh-did-resolver.test.ts. File contents are unchanged — done viagit mv, tracked as renames.Changeset: added (
@agentcommercekit/did, patch).Verified locally:
vitest run src/did-resolvers/pkh-did-resolver.test.ts(4/4 passing, confirming all did:pkh test vectors — including the unknown-DID error case — still resolve correctly against the renamed fixtures),oxlintandoxfmt --checkclean.AI usage disclosure (per AI_POLICY.md): this fix was developed with Claude (Anthropic) assistance — identifying the fixture files as the root cause, renaming them, updating the import paths, and verifying locally. I reviewed and understand the change: three files were renamed (
git mv, content untouched) and three import statements in one test file were updated to match the new filenames.