Skip to content

fix(did): rename did:pkh test fixtures to remove Windows-invalid colons #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ygd58 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(did): rename did:pkh test fixtures to remove Windows-invalid colons #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/windows-fixture-filenames.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
"@agentcommercekit/did": patch
---

Rename `did:pkh` test fixture files to remove `:` characters, which are
invalid in Windows filenames

The three JSON fixtures under `test-fixtures/did-pkh/` used the literal
`did:pkh:...` URI (colons included) as their filename. `:` is a reserved
character on Windows/NTFS, so these files failed to check out correctly on
Windows, breaking `pkh-did-resolver.test.ts` for Windows contributors and CI
runners.

Renamed the three fixtures to replace `:` with `_` (e.g.
`did_pkh_eip155_1_0x....json`) and updated the corresponding static imports
in `pkh-did-resolver.test.ts`. File contents are unchanged.
6 changes: 3 additions & 3 deletions packages/did/src/did-resolvers/pkh-did-resolver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { describe, expect, it } from "vitest"

import fixtureEthereumMainnet from "../../test-fixtures/did-pkh/did:pkh:eip155:1:0xb9c5714089478a327f09197987f16f9e5d936e8a.json"
import fixtureBaseSepolia from "../../test-fixtures/did-pkh/did:pkh:eip155:84532:0xa0ae58da58dfa46fa55c3b86545e7065f90ff011.json"
import fixtureSolana from "../../test-fixtures/did-pkh/did:pkh:solana:4sGjMW1sUnHzSxGspuhpqLDx6wiyjNtZ:CKg5d12Jhpej1JqtmxLJgaFqqeYjxgPqToJ4LBdvG9Ev.json"
import fixtureEthereumMainnet from "../../test-fixtures/did-pkh/did_pkh_eip155_1_0xb9c5714089478a327f09197987f16f9e5d936e8a.json"
import fixtureBaseSepolia from "../../test-fixtures/did-pkh/did_pkh_eip155_84532_0xa0ae58da58dfa46fa55c3b86545e7065f90ff011.json"
import fixtureSolana from "../../test-fixtures/did-pkh/did_pkh_solana_4sGjMW1sUnHzSxGspuhpqLDx6wiyjNtZ_CKg5d12Jhpej1JqtmxLJgaFqqeYjxgPqToJ4LBdvG9Ev.json"
import { resolve } from "./pkh-did-resolver"

/**
Expand Down
0 ...714089478a327f09197987f16f9e5d936e8a.json → ...714089478a327f09197987f16f9e5d936e8a.json
View file
Open in desktop
File renamed without changes.
0 ...58da58dfa46fa55c3b86545e7065f90ff011.json → ...58da58dfa46fa55c3b86545e7065f90ff011.json
View file
Open in desktop
File renamed without changes.
0 ...hpej1JqtmxLJgaFqqeYjxgPqToJ4LBdvG9Ev.json → ...hpej1JqtmxLJgaFqqeYjxgPqToJ4LBdvG9Ev.json
View file
Open in desktop
File renamed without changes.