Conversation
ashnohe
requested review from
alabiaga,
madebymozart and
yrezgui
as code owners
September 21, 2026 22:18
yrezgui
requested changes
Sep 22, 2026
| GlanceTheme.colors.tertiary | ||
| } else { | ||
| ColorProvider(Color.Transparent, Color.Transparent) | ||
| androidx.glance.color.ColorProvider(Color.Transparent, Color.Transparent) |
Contributor
There was a problem hiding this comment.
I'm confused this is referring to what. I've checked androidx.glance.color.ColorProvider and it doesn't seem to exist. Can you double check?
Contributor
Author
There was a problem hiding this comment.
It exists. This is the day / night constructor: https://developer.android.com/reference/kotlin/androidx/glance/color/package-summary#ColorProvider(androidx.compose.ui.graphics.Color,androidx.compose.ui.graphics.Color)
Confusingly, this file uses two ColorProviders
- https://developer.android.com/reference/kotlin/androidx/glance/color/package-summary#ColorProvider(androidx.compose.ui.graphics.Color,androidx.compose.ui.graphics.Color)
- https://developer.android.com/reference/kotlin/androidx/glance/unit/ColorProvider
Having both in the import was causing build errors in a skill I'm working on so I decided to remove one import and fully qualify the other.
ashnohe
enabled auto-merge
September 22, 2026 02:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.