Skip to content

minor fixes to Glance canonical widget layouts #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashnohe wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −14
Open

minor fixes to Glance canonical widget layouts #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions ...n/java/com/example/platform/ui/appwidgets/glance/layout/collections/ImageGridAppWidget.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,19 @@ class ImageGridAppWidget : GlanceAppWidget() {
val items by repo.data().collectAsState(initial = initialItems)
val coroutineScope = rememberCoroutineScope()

GlanceTheme
key(LocalSize.current) {
WidgetContent(
items = items,
refreshAction = {
coroutineScope.launch {
withContext(Dispatchers.IO) {
repo.refresh(context)
}
}
GlanceTheme {
key(LocalSize.current) {
WidgetContent(
items = items,
refreshAction = {
coroutineScope.launch {
withContext(Dispatchers.IO) {
repo.refresh(context)
}
}
}
)
}
)
}
}
}
Expand Down
5 changes: 2 additions & 3 deletions ...m/example/platform/ui/appwidgets/glance/layout/toolbars/layout/ExpressiveToolbarLayout.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ import androidx.glance.action.clickable
import androidx.glance.appwidget.appWidgetBackground
import androidx.glance.appwidget.cornerRadius
import androidx.glance.background
import androidx.glance.color.ColorProvider
import androidx.glance.layout.Alignment
import androidx.glance.layout.Box
import androidx.glance.layout.fillMaxSize
Expand Down Expand Up @@ -235,7 +234,7 @@ private fun CornerButton(
contentDescription = toolBarButton.contentDescription,
iconSize = iconSize,
backgroundSize = buttonBackgroundSize,
backgroundColor = ColorProvider(Color.Transparent, Color.Transparent),
backgroundColor = androidx.glance.color.ColorProvider(Color.Transparent, Color.Transparent),
contentColor = GlanceTheme.colors.primary,
roundedCornerShape = RoundedCornerShape.FULL,
onClick = toolBarButton.onClick,
Expand All @@ -255,7 +254,7 @@ private fun CenterButton(
val backgroundColor = if (filled) {
GlanceTheme.colors.tertiary
} else {
ColorProvider(Color.Transparent, Color.Transparent)
androidx.glance.color.ColorProvider(Color.Transparent, Color.Transparent)

@yrezgui yrezgui Sep 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused this is referring to what. I've checked androidx.glance.color.ColorProvider and it doesn't seem to exist. Can you double check?

@ashnohe ashnohe Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It exists. This is the day / night constructor: https://developer.android.com/reference/kotlin/androidx/glance/color/package-summary#ColorProvider(androidx.compose.ui.graphics.Color,androidx.compose.ui.graphics.Color)

Confusingly, this file uses two ColorProviders

Having both in the import was causing build errors in a skill I'm working on so I decided to remove one import and fully qualify the other.

}

val contentColor = if (filled) {
Expand Down
Loading