Clean up stale comments and in-place uncertainty ops in Combiner - #980
Merged
Merged
Conversation
mwcraig
force-pushed
the
cleanup-combiner-stale-comments
branch
from
August 22, 2026 17:46
591c0b9 to
2b329d1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
==========================================
- Coverage 96.32% 96.31% -0.01%
==========================================
Files 9 9
Lines 1685 1684 -1
==========================================
- Hits 1623 1622 -1
Misses 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mwcraig
marked this pull request as ready for review
August 22, 2026 18:24
mwcraig
force-pushed
the
cleanup-combiner-stale-comments
branch
2 times, most recently
from
August 23, 2026 14:54
89d9718 to
89e6776
Compare
The comments in median_combine, average_combine and sum_combine still referred to numpy and to astropy#351 although the code converts the uncertainty into the combiner's array namespace. Rewrite them to describe what the code does, drop a redundant xp.asarray call, and replace the in-place ``/=`` and ``*=`` on the uncertainty with rebinding so the methods do not rely on mutable arrays. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTN9DnPnLKK2u7knnMJ2gA
mwcraig
force-pushed
the
cleanup-combiner-stale-comments
branch
from
August 23, 2026 17:55
89e6776 to
c37c0de
Compare
45 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#978 is merged; this is now rebased onto
mainand stands alone as a single commit.Small cleanup of the
Combiner.median_combine/average_combine/sum_combinemethods:uncertainty_func, notnp.ma.median).# Convert uncertainty to plain numpy array (#351)comments (the code converts to the combiner's array namespace viaxp.asarray).uncertainty = xp.asarray(uncertainty)inmedian_combine.uncertainty /= .../uncertainty *= ...as rebinding so the methods do not rely on mutable arrays (immutable backends such as jax).No behaviour change; no new tests. The diff is
CHANGES.rst(+3) andccdproc/combiner.py(+21/-23).Test matrix
Measured on this branch after the rebase. Every figure is identical to
mainat 034c77e, which is the point of a no-behaviour-change cleanup.pytest ccdprocmainJAX_ENABLE_X64=True)test_combiner.pyThe strict
test_combiner.pyfailures are pre-existing and tracked in #971 — device andnp.asarrayboundary issues, unrelated to this cleanup.An earlier revision of this description quoted a
393 / 379 / 383matrix and "74 failed, 13 passed" under strict. Those predate both #985 (which added coverage upload from the jax and dask jobs) and the rebase onto the reviewed #978, and are superseded by the table above.🤖 Generated with Claude Code
https://claude.ai/code/session_01DTN9DnPnLKK2u7knnMJ2gA