refactor(review): move review policy behind VCS providers - #1499
Open
graemefolk wants to merge 1 commit into
Open
refactor(review): move review policy behind VCS providers#1499graemefolk wants to merge 1 commit into
graemefolk wants to merge 1 commit into
Conversation
graemefolk
force-pushed
the
refactor/vcs-review-policies
branch
from
September 10, 2026 18:44
4db9c61 to
78707af
Compare
chore: sync guide viewer manifest fix(review): validate provider diff ids before narrowing
graemefolk
force-pushed
the
refactor/vcs-review-policies
branch
from
September 10, 2026 18:59
78707af to
e7b29f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review started as a Git-only feature, so assumptions about Git gradually spread into shared configuration, command parsing, startup, and UI code. As support for Jujutsu, GitButler, and Perforce was added, those shared modules also began listing each provider's diff modes and deciding what their options meant.
That made the architecture harder to extend safely. Adding or changing a provider could require edits across several unrelated parts of the application, and a generic code path could accidentally apply Git behavior to another version-control system.
This refactor gives each version-control provider responsibility for its own review behavior. Shared code now asks the selected provider how to interpret a diff mode instead of maintaining a central list of provider-specific rules.
What changed
Existing Git, Jujutsu, GitButler, and Perforce review behavior remains unchanged. The practical improvement is that future provider-specific settings and diff modes can be added in the provider that owns them, without teaching the rest of the application about that provider.
Validation
Related work
Draft PR #1500 adds the Jujutsu-specific review settings that this structure is intended to support. It currently includes this refactor in its GitHub diff and will be rebased onto
mainafter this PR lands.