Skip to content

feat(review): add Jujutsu review defaults - #1500

Draft
graemefolk wants to merge 2 commits into
backnotprop:mainfrom
graemefolk:feat/jj-review-defaults
Draft

feat(review): add Jujutsu review defaults#1500
graemefolk wants to merge 2 commits into
backnotprop:mainfrom
graemefolk:feat/jj-review-defaults

Conversation

@graemefolk

@graemefolk graemefolk commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Plannotator already supports reviewing Jujutsu repositories, but the saved review preferences are still presented as Git settings. That makes it unclear which choices apply to Jujutsu and prevents Jujutsu users from choosing a default that matches how they work.

This builds on #1499, which moves review behavior into the version-control provider that owns it. Until that refactor is merged, this PR will remain in draft and show the diff for both sets of changes. Commit 738d482 shows just the changes intended for this PR.

What changed

  • Renamed the Git settings area to Review.
  • Added separate Git and Jujutsu sections under Review settings.
  • Added Jujutsu choices for Current change, Line of work, Last change, Evolution diff, and All files.
  • Saved defaults separately for each provider so changing a Git preference does not replace a Jujutsu preference, or vice versa.
  • Kept support for existing Git preferences so current users retain their configured behavior.
  • Sent the available provider settings to the review UI from both the Bun and Pi servers.
  • Added Jujutsu support for opening a review with its native diff modes and an explicit base for Line of work.

GitButler and P4 implementations were not added. They could be added in subsequent PRs.

Validation

  • Shared policy, configuration, VCS, and review-state tests
  • Pi parity tests and TypeScript checks
  • Server TypeScript check
  • Review and hook production builds
  • Browser verification in Vivaldi for both Jujutsu and Git sessions, including saving independent defaults, relaunching with the Jujutsu Line of work default, and switching review views

chore: sync guide viewer manifest

fix(review): validate provider diff ids before narrowing
resolve validated diff type stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant