feat(review): add Jujutsu review defaults - #1500
Draft
graemefolk wants to merge 2 commits into
Draft
Conversation
chore: sync guide viewer manifest fix(review): validate provider diff ids before narrowing
resolve validated diff type stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plannotator already supports reviewing Jujutsu repositories, but the saved review preferences are still presented as Git settings. That makes it unclear which choices apply to Jujutsu and prevents Jujutsu users from choosing a default that matches how they work.
This builds on #1499, which moves review behavior into the version-control provider that owns it. Until that refactor is merged, this PR will remain in draft and show the diff for both sets of changes. Commit 738d482 shows just the changes intended for this PR.
What changed
GitButler and P4 implementations were not added. They could be added in subsequent PRs.
Validation