chore(ios-runner): delete the unreachable synthesized continuous drag profile - #2825
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
Reviewed at a72db65: the code looks correct. Every The Smoke Tests failure in |
thymikee
added this pull request to stack #2830
September 23, 2026 15:34
… profile The only daemon producer of the runner `drag` command is macOS-only and never sets `synthesized`, so the smoothstep `.continuous` profile could not run. Remove the ObjC continuous path and frame-count export, the Swift enum case, the `synthesized:` parameter and second synthesized block in `executeDragGesture`, and its frame-count test. `.fastSwipe` and `.controlledScroll` are untouched; ADR 0013 now describes the scroll schedule that remains. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…one optional Plain coordinate drags no longer name a synthesized policy they never apply; the activation-preflight drag fixture stops sending the ignored flag. ADR 0011 and 0013 describe the synthesized lanes that remain. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
thymikee
force-pushed
the
chore/2790-drop-continuous-drag
branch
from
September 23, 2026 18:08
a72db65 to
3b3fd27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the synthesized
.continuous(smoothstep) drag profile. Nothing could reach it: the only daemondragproducer is macOS-only and never setssynthesized..continuouscase, and inexecuteDragGesturethesynthesized:flag and the second synthesized block. Profile and policy now travel as one optional..fastSwipeand.controlledScrollare unchanged byte for byte. ADR 0013 and 0011 now describe the lanes that remain.Two ways the current code differs from the issue: a runner
dragthat setssynthesizednow runs a plain coordinate drag, and a non-iOSgestureendpoint-hold plan (which the daemon never sends) no longer reportsgestureFallback.8 files, +33/−152. Closes #2790
Validation
Rebased onto
mainata913cb222. Signed macOS host lane: 236/236 at3b3fd2766(+2 tests from main).check:affected --runis green at the stack head60e533284. The evidence below is from before the rebase.Tested at
a72db6538.check:affected --run,check:xctest-selection, andformat:checkpass.grep -rni continuousin the runner UITests finds only a text-entry comment.01-navigation-scroll(swipe plus scroll edges),02-checkout-release,gesture-pan-duration, anddragreplays pass. Runner log showsagent-device-controlled-scrollandagent-device-swiperecords.scrollsteps.snapshot-depth-frontierfailed because it expects the AX-bridge backend and gotxctesthere; that is unrelated snapshot code, so CI is authoritative.synthesizedondrag(that would be a new compatibility path).🤖 Generated with Claude Code