You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use the shared WAIT_REASONS taxonomy in the iOS deep-link confirmation helper and its fixtures. A taxonomy rename now updates the retry branches through a typed import instead of silently leaving stale string comparisons.
Commit 14cb69fe19: focused deep-link confirmation suite 10/10; pnpm check:affected --run passed all runnable checks. All exact-head GitHub checks passed, including iOS Smoke Tests. This is a taxonomy-only change; the original #2902 simulator evidence remains attributed to its merged head.
This looks correct at 14cb69f. The diff only swaps raw wait-reason string literals for the WAIT_REASONS constants in the confirmation helper, and CI confirms it: iOS Smoke Tests and all 18 checks pass on this head, consistent with a no-op taxonomy substitution.
I did not independently re-run the live iOS simulator confirmation suite; I'm relying on the PR body's 10/10 claim and the passing iOS Smoke Tests check, since this is a verified no-op string substitution rather than new behavior. I also did not check whether other iOS e2e helpers or fixtures still use raw wait-reason string literals instead of WAIT_REASONS; that's outside this narrow follow-up's scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thymikee
added
the
ready-for-human
Summary
Use the shared
WAIT_REASONStaxonomy in the iOS deep-link confirmation helper and its fixtures. A taxonomy rename now updates the retry branches through a typed import instead of silently leaving stale string comparisons.Follow-up to the #2902 review note. Two files touched.
Validation
Commit
14cb69fe19: focused deep-link confirmation suite 10/10;pnpm check:affected --runpassed all runnable checks. All exact-head GitHub checks passed, including iOS Smoke Tests. This is a taxonomy-only change; the original #2902 simulator evidence remains attributed to its merged head.