Skip to content

refactor(ios-e2e): use canonical wait reasons in confirmation helper #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Sep 24, 2026
+9 −6
Merged

refactor(ios-e2e): use canonical wait reasons in confirmation helper #2919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/integration/ios-simulator-e2e-deep-link-confirmation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import assert from 'node:assert/strict';
import test from 'node:test';

import { WAIT_REASONS } from '@agent-device/contracts/wait';
import type { CliJsonResult } from './cli-json.ts';
import {
answerDeepLinkConfirmation,
Expand All @@ -15,16 +16,16 @@ const LANDED = result(0, { success: true });
const LAUNCH_PENDING = result(1, {
error: {
code: 'COMMAND_FAILED',
details: { reason: 'wait_capture_stalled', runnerErrorCode: 'APP_NOT_RUNNING' },
details: { reason: WAIT_REASONS.captureStalled, runnerErrorCode: 'APP_NOT_RUNNING' },
},
});
const WRONG_ROUTE = result(1, {
error: { code: 'COMMAND_FAILED', details: { reason: 'wait_target_absent' } },
error: { code: 'COMMAND_FAILED', details: { reason: WAIT_REASONS.targetAbsent } },
});
const READABLE_TIMEOUT = result(1, {
error: {
code: 'COMMAND_FAILED',
details: { reason: 'wait_deadline_exceeded', readableCaptures: 5, captureTruncated: true },
details: { reason: WAIT_REASONS.deadlineExceeded, readableCaptures: 5, captureTruncated: true },
},
});
const OPEN_PROMPT = result(0, {
Expand Down
8 changes: 5 additions & 3 deletions test/integration/ios-simulator-e2e/live-deep-link-confirmation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import assert from 'node:assert/strict';

import { WAIT_REASONS } from '@agent-device/contracts/wait';
import type { CliJsonResult } from '../cli-json.ts';
import { type LiveContext, runStep } from './live-harness.ts';

Expand Down Expand Up @@ -59,12 +60,13 @@ export async function answerDeepLinkConfirmation(
const details = arrived.json?.error?.details;
const launchPending = details?.runnerErrorCode === APP_NOT_RUNNING;
const reason = details?.reason;
const readableMiss = reason === 'wait_target_absent' || reason === 'wait_deadline_exceeded';
const readableMiss =
reason === WAIT_REASONS.targetAbsent || reason === WAIT_REASONS.deadlineExceeded;
const interruptedCapture =
reason === 'wait_capture_stalled' || reason === 'wait_runner_restart_exhausted';
reason === WAIT_REASONS.captureStalled || reason === WAIT_REASONS.runnerRestartExhausted;
if (!launchPending && !readableMiss && !interruptedCapture) return;
if (!answered) answered = await acceptOpenConfirmation(device);
if (!answered && reason === 'wait_target_absent') return;
if (!answered && reason === WAIT_REASONS.targetAbsent) return;
}
}

Expand Down
Loading