Keep containerd's rpmbuild.env if it exists. - #524
Open
Romain-Geissler-1A wants to merge 1 commit into
Open
Romain-Geissler-1A wants to merge 1 commit into
Romain-Geissler-1A wants to merge 1 commit into
Conversation
It seems that RPM 6 coming with Fedora 45 does create this rpmbuild.env file in the build directory and expects it at each step of rpmbuild. For a reason I don't get, we don't use any %setup directive, we totally remove thing existing build directory, and we symlink one from the gopath. It seems weird, and it's the root cause of the issue. Since I have no idea why we do that, for now I propose just a simple workaround, but I think on the longer term we shall also have some %setup directive like other packages do. This is a pre-requisite to allow building packages for Fedora 45. Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
Contributor
Author
|
@vvoland Do you know why we have no %setup only in containerd's spec file ? Seems weird. |
Open
Collaborator
|
Looks like it was to workaround some difficulty when containerd was still using the GOPATH mode: 7c9e7aa I don't think there is any reason to do it anymore If you have some time to do move to |
Contributor
Author
|
Pull request on hold, most likely will be replaced by #525 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that RPM 6 coming with Fedora 45 does create this rpmbuild.env file in the build directory and expects it at each step of rpmbuild. For a reason I don't get, we don't use any %setup directive, we totally remove thing existing build directory, and we symlink one from the gopath. It seems weird, and it's the root cause of the issue. Since I have no idea why we do that, for now I propose just a simple workaround, but I think on the longer term we shall also have some %setup directive like other packages do.
This is a pre-requisite to allow building packages for Fedora 45.