Use %setup macros for containerd. - #525
Romain-Geissler-1A wants to merge 1 commit into
Conversation
3d2f4f3 to
362c2cc
Compare
|
In this version we totally ignore the %source content, and we build from /go/src. We did "a bit" that before as well. In other packages like docker-cli we seem to remove partially the content of /go/src to replace it by the content of the %source. Not sure what you want exactly. I guess we really want to build in /go/src to have stable builds and debug symbols that contain a fixed /go/src path ? I can change that if you prefer another direction. |
cfd1951 to
d29d375
Compare
|
I think the main reason wasn't for path consistent, but for the Git metadata present in But using the source from %setup would be more idiomatic and I think that's what we actually do for the other packages? |
51f4925 to
a986270
Compare
This is a pre-requisite for building a containerd package for Fedora 45. Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
a986270 to
d2673be
Compare
|
Ok @vvoland I also stopped using the checked out source files with the .git folders, now we use only the %sourceN plus the gen-ver rpm defines (I had to add one for the runc commit). It's ready for review. |
This is a pre-requisite for building a containerd package for Fedora 45.
As discussed in #524.