Skip to content

Use %setup macros for containerd. - #525

Open
Romain-Geissler-1A wants to merge 1 commit into
docker:mainfrom
Romain-Geissler-1A:use-setup-macro-for-containerd
Open

Romain-Geissler-1A wants to merge 1 commit into
docker:mainfrom
Romain-Geissler-1A:use-setup-macro-for-containerd

Conversation

@Romain-Geissler-1A

Copy link
Copy Markdown
Contributor

This is a pre-requisite for building a containerd package for Fedora 45.

As discussed in #524.

@Romain-Geissler-1A
Romain-Geissler-1A requested a review from a team as a code owner September 28, 2026 11:08
@Romain-Geissler-1A
Romain-Geissler-1A force-pushed the use-setup-macro-for-containerd branch 7 times, most recently from 3d2f4f3 to 362c2cc Compare September 28, 2026 11:35
@Romain-Geissler-1A

Copy link
Copy Markdown
Contributor Author

In this version we totally ignore the %source content, and we build from /go/src. We did "a bit" that before as well. In other packages like docker-cli we seem to remove partially the content of /go/src to replace it by the content of the %source. Not sure what you want exactly. I guess we really want to build in /go/src to have stable builds and debug symbols that contain a fixed /go/src path ?

I can change that if you prefer another direction.

@Romain-Geissler-1A
Romain-Geissler-1A force-pushed the use-setup-macro-for-containerd branch 2 times, most recently from cfd1951 to d29d375 Compare September 28, 2026 11:45
@vvoland

vvoland commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

I think the main reason wasn't for path consistent, but for the Git metadata present in /go/src. Probably for runc version?

But using the source from %setup would be more idiomatic and I think that's what we actually do for the other packages?

@Romain-Geissler-1A
Romain-Geissler-1A force-pushed the use-setup-macro-for-containerd branch 2 times, most recently from 51f4925 to a986270 Compare September 28, 2026 13:33
This is a pre-requisite for building a containerd package for Fedora 45.

Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
@Romain-Geissler-1A
Romain-Geissler-1A force-pushed the use-setup-macro-for-containerd branch from a986270 to d2673be Compare September 28, 2026 14:07
@Romain-Geissler-1A
Romain-Geissler-1A requested a review from a team as a code owner September 28, 2026 14:07
@Romain-Geissler-1A

Copy link
Copy Markdown
Contributor Author

Ok @vvoland I also stopped using the checked out source files with the .git folders, now we use only the %sourceN plus the gen-ver rpm defines (I had to add one for the runc commit). It's ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants