Skip to content

JIT: contain shifts into byref ADD on arm64 #132221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EgorBo wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −4
Open

JIT: contain shifts into byref ADD on arm64 #132221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91e1409
JIT: allow containing shift/mul/cast into byref ADD/SUB on arm64
EgorBo Aug 12, 2026
e23683b
Merge branch 'main' into arm64-contain-shift-byref
EgorBo Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/coreclr/jit/codegenarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2702,7 +2702,7 @@ void CodeGen::genCodeForBinary(GenTreeOp* tree)
if (op2->OperIs(GT_MUL) && op2->isContained())
{
// In the future, we might consider enabling this for floating-point "unsafe" math.
assert(varTypeIsIntegral(tree));
assert(varTypeIsIntegral(tree) || tree->TypeIs(TYP_BYREF));

// These operations cannot set flags
assert((tree->gtFlags & GTF_SET_FLAGS) == 0);
Expand Down Expand Up @@ -2740,7 +2740,7 @@ void CodeGen::genCodeForBinary(GenTreeOp* tree)
}
else if (op2->OperIs(GT_LSH, GT_RSH, GT_RSZ) && op2->isContained())
{
assert(varTypeIsIntegral(tree));
assert(varTypeIsIntegral(tree) || tree->TypeIs(TYP_BYREF));

GenTree* a = op1;
GenTree* b = op2->gtGetOp1();
Expand Down Expand Up @@ -2799,6 +2799,7 @@ void CodeGen::genCodeForBinary(GenTreeOp* tree)
}
else if (op2->OperIs(GT_ROR) && op2->isContained())
{
// ROR is only contained under AND/OR/XOR parents, which are never TYP_BYREF.
assert(varTypeIsIntegral(tree));

GenTree* a = op1;
Expand Down Expand Up @@ -2841,7 +2842,7 @@ void CodeGen::genCodeForBinary(GenTreeOp* tree)
}
else if (op2->OperIs(GT_CAST) && op2->isContained())
{
assert(varTypeIsIntegral(tree));
assert(varTypeIsIntegral(tree) || tree->TypeIs(TYP_BYREF));

GenTree* a = op1;
GenTree* b = op2->AsCast()->CastOp();
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/lowerarmarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ bool Lowering::IsContainableUnaryOrBinaryOp(GenTree* parentNode, GenTree* childN
if (parentNode->isContained())
return false;

if (!varTypeIsIntegral(parentNode))
if (!varTypeIsIntegral(parentNode) && !parentNode->TypeIs(TYP_BYREF))
return false;
Comment on lines 196 to 200

if (parentNode->gtGetOp1()->isContained() || (parentNode->OperIsBinary() && parentNode->gtGetOp2()->isContained()))
Expand Down
Loading