Remove redundant dependency passes in Mix.Compilers.Elixir - #15918
Merged
josevalim merged 1 commit intoSep 20, 2026
Merged
Conversation
deps_on collected unaffected dependencies and retried them whenever a pass found another affected app. Mix.Dep.cached/0 already places dependencies before their dependents, so these retries cannot discover additional affected apps. Assisted-by: Codex:GPT-6
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Codex:GPT-6
deps_on/1propagates config and lock changes through the dependency graph to determine which applications’ modules may require recompilation. It currently accumulates unaffected dependencies and retries them if the pass adds any affected apps.Mix.Dep.cached/0already returns dependencies before their dependents. Convergence topologically sorts the graph, and both caching and child-project filtering preserve that order. Each dependency’s affected status is therefore final when visited, so retrying previously unaffected dependencies cannot add anything to the result.Remove the pending list, progress flag, and retry pass while preserving the same affected-app map and existing short circuit for apps already marked.