Skip to content

Remove redundant dependency passes in Mix.Compilers.Elixir #15918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Sep 20, 2026
+7 −8
Merged

Remove redundant dependency passes in Mix.Compilers.Elixir #15918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions lib/mix/lib/mix/compilers/elixir.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,27 +900,26 @@ defmodule Mix.Compilers.Elixir do

defp deps_on(apps) do
apps = Map.from_keys(apps, true)
deps_on(Mix.Dep.cached(), apps, [], false)
deps_on(Mix.Dep.cached(), apps)
end

defp deps_on([%{app: app, deps: deps} = dep | cached_deps], apps, acc, stored?) do
defp deps_on([%{app: app, deps: deps} | cached_deps], apps) do
cond do
# We have already seen this dep
Map.has_key?(apps, app) ->
deps_on(cached_deps, apps, acc, stored?)
deps_on(cached_deps, apps)

# It depends on one of the apps, store it
Enum.any?(deps, &Map.has_key?(apps, &1.app)) ->
deps_on(cached_deps, Map.put(apps, app, true), acc, true)
deps_on(cached_deps, Map.put(apps, app, true))

# Otherwise we will check it later
# Otherwise it is unaffected
true ->
deps_on(cached_deps, apps, [dep | acc], stored?)
deps_on(cached_deps, apps)
end
end

defp deps_on([], apps, cached_deps, true), do: deps_on(cached_deps, apps, [], false)
defp deps_on([], apps, _cached_deps, false), do: apps
defp deps_on([], apps), do: apps

## Manifest handling

Expand Down
Loading