Make sequence puzzle hint signs optional - #2924
Open
BiancaPierina wants to merge 2 commits into
Open
BiancaPierina wants to merge 2 commits into
BiancaPierina wants to merge 2 commits into
Conversation
|
Play this branch at https://play.threadbare.game/branches/BiancaPierina/sequence-puzzle-optional-hint-signs/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Contributor
|
Hola! He estado probando los cambios que hiciste y he visto que funcionan correctamente. En todo caso recomiendo que resuelvas el check de formateo del codigo, la forma mas sencilla es instalar pre-commit como se indica aqui. |
Collaborator
|
@Un-player0 thank you so much for the peer review! @BiancaPierina let us know when it's ready for review again. |
- Removed the editor warning that required a hint sign. - Added is_solved to SequencePuzzleStep. - Updated SequencePuzzle to use step-level solved state. - Added null guards around all hint_sign access.
BiancaPierina
force-pushed
the
sequence-puzzle-optional-hint-signs
branch
from
September 21, 2026 19:33
08d7144 to
1a4965c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2149