turn on bulk sync by default - #115
Merged
Merged
Conversation
Signed-off-by: Eric Pickard <piceri@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Enables bulk cluster synchronization by default and documents the new default.
Changes:
- Defaults
BULK_CLUSTER_SYNCtotrue. - Adds the setting to the environment-variable documentation.
Show a summary per file
| File | Description |
|---|---|
README.md |
Documents bulk-sync configuration and default. |
cmd/deployment-tracker/main.go |
Enables bulk startup synchronization by default. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
Contributor
|
Lgtm, but we'll also need to clean up the experimental comment here: https://github.com/github/deployment-tracker/blob/main/internal/controller/config.go#L34 |
Signed-off-by: Eric Pickard <piceri@github.com>
ajbeattie
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turn on bulk sync by default