Skip to content

turn on bulk sync by default #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piceri merged 2 commits into from
Jul 27, 2026
+3 −3
Merged

turn on bulk sync by default #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3e2433
turn on bulk sync by default
piceri Jul 27, 2026
1fcf353
remove experimental comment
piceri Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ Two modes of authentication are supported:
| `LOGICAL_ENVIRONMENT` | Logical environment name | (required) |
| `PHYSICAL_ENVIRONMENT` | Physical environment name | `""` |
| `CLUSTER` | Cluster name | (required) |
| `BULK_CLUSTER_SYNC` | Bulk-sync cluster state at startup | `true` |
| `API_TOKEN` | API authentication token | `""` |
| `GH_APP_ID` | GitHub App ID | `""` |
| `GH_INSTALL_ID` | GitHub App installation ID | `""` |
Expand Down
2 changes: 1 addition & 1 deletion cmd/deployment-tracker/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func main() {
GHAppPrivateKey: ghAppPrivateKey,
GHAppPrivateKeyPath: getEnvOrDefault("GH_APP_PRIV_KEY_PATH", ""),
Organization: os.Getenv("GITHUB_ORG"),
BulkClusterSync: strings.EqualFold(getEnvOrDefault("BULK_CLUSTER_SYNC", "false"), "true"),
BulkClusterSync: strings.EqualFold(getEnvOrDefault("BULK_CLUSTER_SYNC", "true"), "true"),
Comment thread
piceri marked this conversation as resolved.
}

if len(cntrlCfg.GHAppPrivateKey) > 0 && cntrlCfg.GHAppPrivateKeyPath != "" {
Expand Down
3 changes: 1 addition & 2 deletions internal/controller/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ type Config struct {
Organization string
// BulkClusterSync enables the async cluster job endpoint for startup
// state sync. When false, startup sync is skipped and only individual
// PostOne calls are used. **Note: this is experimental and not yet available
// for public use.**
// PostOne calls are used.
BulkClusterSync bool
}

Expand Down