Document explicit upstream proxy port fix in runner-doctor B2 catalog - #8925
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Update B2 corporate proxy with explicit-port proxy-parsing fix
Document explicit upstream proxy port fix in runner-doctor B2 catalog
Sep 23, 2026
lpcox
marked this pull request as ready for review
September 23, 2026 20:09
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation accurately reflects the implemented proxy-port behavior and remains synchronized with focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Documents the upstream proxy explicit-port fix in the runner-doctor B2 catalog and keeps both catalog copies aligned.
Changes:
- Adds B2 diagnosis, remediation, probe, and citations for #8877/#8887.
- Adds regression assertions for both catalog copies.
| File | Description |
|---|---|
.github/workflows/shared/self-hosted-failure-modes.md |
Expands the canonical B2 entry. |
.github/agents/self-hosted-runner-doctor.md |
Mirrors the updated B2 guidance. |
scripts/ci/self-hosted-runner-doctor-workflow.test.ts |
Verifies the new guidance and citations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
✅ Copilot review passed with no inline comments. @copilot Add the |
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The self-hosted runner doctor knowledge base's B2 entry (mandatory corporate proxy) only covered the
PROXY_ENV_VARSallowlist fix from #6267. It did not capture the explicit-port parsing bug (#8877) fixed in #8887, where a corporate proxy genuinely listening on port 80 was silently rewritten to Squid's3128default, breaking allcache_peerchaining.Changes
.github/workflows/shared/self-hosted-failure-modes.md— extended the B2 row across three columns:parseProxyUrl()(src/upstream-proxy.ts) lost explicitly-supplied default ports becauseURLnormalization strips:80. The fix reads the raw authority port viagetExplicitProxyPort()before normalization, keeps the3128fallback only when no port was supplied, and rejects explicitly-empty ports. Applies to both hosthttps_proxy/http_proxyauto-detection and--upstream-proxy.https_proxy=http://proxy.corp.example.com:80and check the generatedsquid.conf— acache_peerport of3128instead of80confirms the unpatched bug.#8877,#8887..github/agents/self-hosted-runner-doctor.md— mirrored the identical row edit in the embedded catalog table.scripts/ci/self-hosted-runner-doctor-workflow.test.ts— assertions pinning the new B2 text and citation suffix in both catalog copies, consistent with the existing alignment checks.No playbook paragraph or error-string lookup entry exists for B2 in either file, so the catalog row is the sole entry point.
self-hosted-runner-doctor.mdtranscludes the shared file via{{#runtime-import}}, so no lock recompile is needed.Behavior being documented
Documentation and test-only; no production code is modified.