fix(ci): fix windows exempt test matching in run_conditional_tests.sh - #9222
Open
bshaffer wants to merge 2 commits into
Open
fix(ci): fix windows exempt test matching in run_conditional_tests.sh#9222bshaffer wants to merge 2 commits into
bshaffer wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Windows test exemption logic in ci/run_conditional_tests.sh by replacing a regex match with a loop that performs prefix matching. The review feedback correctly identifies a potential issue where prefix matching can cause false positives (e.g., matching packages/foo-bar when packages/foo is exempt) and provides a code suggestion to ensure precise matching for exact directories or subdirectories.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
feywind
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows test exemption prefix matching in
ci/run_conditional_tests.shso that package paths matching entries inwindows_exempt_testsare accurately skipped on Windows runners.