Skip to content

fix(ci): fix windows exempt test matching in run_conditional_tests.sh #9222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bshaffer wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

fix(ci): fix windows exempt test matching in run_conditional_tests.sh #9222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
800984a
fix(ci): fix windows exempt test matching in run_conditional_tests.sh
bshaffer Aug 28, 2026
1d9d7ad
Update ci/run_conditional_tests.sh
bshaffer Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ci/run_conditional_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,14 @@ for subdir in ${subdirs[@]}; do

# Our CI uses Git Bash on Windows to execute this script, which returns "msys" or "cygwin" for OSTYPE.
if [[ "$OSTYPE" == "msys" || "$OSTYPE" == "cygwin" || "$OS" == "Windows_NT" ]]; then
if [[ "${windows_exempt_tests}" =~ "${d}" ]]; then
is_exempt=false
for exempt in ${windows_exempt_tests}; do
if [[ "${d}" == "${exempt}" || "${d}" == "${exempt}/"* ]]; then
is_exempt=true
break
fi
done
if [[ "${is_exempt}" == "true" ]]; then
echo "Skipping ${d} on Windows (in exemption list)"
continue
fi
Expand Down
Loading