feat(django-google-spanner): support Django 6.0 - #18128
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Django 6.0, including dependency updates, tuple-casting for lookup parameters, an asynchronous autocommit setter, and a Spanner-specific JSON path compiler. The review feedback highlights critical improvements: resolving syntax, type, and SQL injection issues in compile_json_path by utilizing json.dumps; wrapping the async autocommit operation in self.execute_wrapper to align with Django standards; and fixing invalid shell syntax and compatibility issues in the new test suite script.
…tion, and address review feedback
… 5.2 compatibility
…s ImportError, mockserver tests, and zizmor pin
…overing indexes, and null ordering
…IS NULL sort expressions
…eFeatures defaults
| "sqlparse >= 0.3.0", | ||
| "google-cloud-spanner >= 3.13.0", | ||
| "django >= 5.2, < 6.0", | ||
| "django >= 4.2, < 6.1", |
There was a problem hiding this comment.
Do we really want to support django 4.2? If so, we should have a corresponding action like packages/django-google-spanner/django_test_suite_6.0.sh
There was a problem hiding this comment.
No. We are no longer supporting 4.2. i will remove this. I am still working on this PR. Will do it before marking it ready
2 participants
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #18053 🦕