feat: migration to SPM only and iOS SDK update to 11.0.0 - #637
Open
illuminati1911 wants to merge 16 commits into
Open
feat: migration to SPM only and iOS SDK update to 11.0.0#637illuminati1911 wants to merge 16 commits into
illuminati1911 wants to merge 16 commits into
Conversation
illuminati1911
marked this pull request as ready for review
August 25, 2026 07:41
illuminati1911
marked this pull request as draft
August 25, 2026 07:42
illuminati1911
marked this pull request as ready for review
August 25, 2026 08:13
jokerttu
requested changes
Aug 28, 2026
| Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green | ||
| use_frameworks! :linkage => linkage.to_sym | ||
| end | ||
| use_frameworks! :linkage => :dynamic |
Contributor
There was a problem hiding this comment.
If we do not read the USE_FRAMEWORKS env parameter anymore, we should not pass it in the ci.yml?
If there is no need to have this USE_FRAMEWORKS env control anymore on sample app, we should remove all mentions of this env variable from the example folder.
| run: | | ||
| cd example/ios | ||
| RCT_NEW_ARCH_ENABLED=0 pod install | ||
| USE_FRAMEWORKS=dynamic pod install |
Contributor
There was a problem hiding this comment.
Using this USE_FRAMEWORKS env variable is removed from the podfile. Should we remove this from here as well.
| * | ||
| * Defaults to true. | ||
| * @deprecated Stop signs are always shown during navigation on iOS Navigation SDK 11+ and | ||
| * this option will be removed in a future release. This option continues to apply on Android. |
Contributor
There was a problem hiding this comment.
Suggested change
| * this option will be removed in a future release. This option continues to apply on Android. | |
| * this option will be removed in a future release. It currently applies only to Android. |
| * | ||
| * Defaults to true. | ||
| * @deprecated Traffic lights are always shown during navigation on iOS Navigation SDK 11+ and | ||
| * this option will be removed in a future release. This option continues to apply on Android. |
Contributor
There was a problem hiding this comment.
Suggested change
| * this option will be removed in a future release. This option continues to apply on Android. | |
| * this option will be removed in a future release. It currently applies only to Android. |
|
|
||
| ### What changed | ||
|
|
||
| Google Navigation is now resolved through Swift Package Manager during `pod install`, rather than through a CocoaPods `GoogleNavigation` dependency. React Native `0.87.0+` is required. CocoaPods continues to manage React Native autolinking and other pods, but it no longer fetches Google Navigation. Configure framework linkage in your app's Podfile according to your app's dependency requirements; the example app uses dynamic frameworks. |
Contributor
There was a problem hiding this comment.
Suggested change
| Google Navigation is now resolved through Swift Package Manager during `pod install`, rather than through a CocoaPods `GoogleNavigation` dependency. React Native `0.87.0+` is required. CocoaPods continues to manage React Native autolinking and other pods, but it no longer fetches Google Navigation. Configure framework linkage in your app's Podfile according to your app's dependency requirements; the example app uses dynamic frameworks. | |
| Google Navigation is now resolved through Swift Package Manager during `pod install`, rather than through a CocoaPods `GoogleNavigation` dependency. CocoaPods continues to manage React Native autolinking and other pods, but it no longer fetches Google Navigation. Configure framework linkage in your app's Podfile according to your app's dependency requirements; the example app uses dynamic frameworks. |
removed mention about RN 0.87.0+ as it is already mandatory for version 0.17.0
| ENV['RCT_NEW_ARCH_ENABLED'] = '1' | ||
| ``` | ||
|
|
||
| #### Swift Package Manager dependency |
Contributor
There was a problem hiding this comment.
I don't think we need to mention about this in README.md as there is no user action here. RN platform handles SPM for this package automatically.
The requirement for RN 0.87.0 for this package is already mentioned above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
11.0.0.0.87+is required.showTrafficLightsandshowStopSignsare now ignored on iOS and remain supported on Android.NSMotionUsageDescription.Pre-launch Checklist