feat: migration to SPM only and iOS SDK update to 11.0.0 #637
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -126,6 +126,21 @@ This package requires React Native's new architecture. Make sure new architectur | |
| ENV['RCT_NEW_ARCH_ENABLED'] = '1' | ||
| ``` | ||
|
|
||
| #### Swift Package Manager dependency | ||
|
Contributor
There was a problem hiding this comment. I don't think we need to mention about this in README.md as there is no user action here. RN platform handles SPM for this package automatically. |
||
|
|
||
| Google Navigation is resolved through Swift Package Manager when you run `pod install`; it is not installed from CocoaPods. This requires React Native 0.87 or later. | ||
|
|
||
| CocoaPods continues to manage React Native autolinking and other pods, but it no longer fetches Google Navigation. Configure framework linkage in your app's Podfile according to your app's dependency requirements; the example app uses dynamic frameworks. | ||
|
|
||
| #### Motion sensor usage description | ||
|
|
||
| Google recommends adding an `NSMotionUsageDescription` entry to your app's `Info.plist` to ensure compatibility with future motion sensor-related functionality in the underlying Navigation SDK for iOS. | ||
|
|
||
| ```xml | ||
| <key>NSMotionUsageDescription</key> | ||
| <string>Used to improve navigation features.</string> | ||
| ``` | ||
|
|
||
| #### Set Google Maps API Key | ||
|
|
||
| To set up, specify your API key in the application delegate `ios/Runner/AppDelegate.m`: | ||
|
|
@@ -301,8 +316,6 @@ try { | |
|
|
||
| const displayOptions: DisplayOptions = { | ||
| showDestinationMarkers: true, | ||
| }; | ||
|
|
||
| await navigationController.setDestinations([waypoint], { routingOptions, displayOptions }); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| GEM | ||
| remote: https://rubygems.org/ | ||
| specs: | ||
| CFPropertyList (3.0.7) | ||
| base64 | ||
| nkf | ||
| rexml | ||
| activesupport (6.1.7.10) | ||
| concurrent-ruby (~> 1.0, >= 1.0.2) | ||
| i18n (>= 1.6, < 2) | ||
| minitest (>= 5.1) | ||
| tzinfo (~> 2.0) | ||
| zeitwerk (~> 2.3) | ||
| addressable (2.8.7) | ||
| public_suffix (>= 2.0.2, < 7.0) | ||
| algoliasearch (1.27.5) | ||
| httpclient (~> 2.8, >= 2.8.3) | ||
| json (>= 1.5.1) | ||
| atomos (0.1.3) | ||
| base64 (0.3.0) | ||
| benchmark (0.4.1) | ||
| bigdecimal (3.2.2) | ||
| claide (1.1.0) | ||
| cocoapods (1.15.2) | ||
| addressable (~> 2.8) | ||
| claide (>= 1.0.2, < 2.0) | ||
| cocoapods-core (= 1.15.2) | ||
| cocoapods-deintegrate (>= 1.0.3, < 2.0) | ||
| cocoapods-downloader (>= 2.1, < 3.0) | ||
| cocoapods-plugins (>= 1.0.0, < 2.0) | ||
| cocoapods-search (>= 1.0.0, < 2.0) | ||
| cocoapods-trunk (>= 1.6.0, < 2.0) | ||
| cocoapods-try (>= 1.1.0, < 2.0) | ||
| colored2 (~> 3.1) | ||
| escape (~> 0.0.4) | ||
| fourflusher (>= 2.3.0, < 3.0) | ||
| gh_inspector (~> 1.0) | ||
| molinillo (~> 0.8.0) | ||
| nap (~> 1.0) | ||
| ruby-macho (>= 2.3.0, < 3.0) | ||
| xcodeproj (>= 1.23.0, < 2.0) | ||
| cocoapods-core (1.15.2) | ||
| activesupport (>= 5.0, < 8) | ||
| addressable (~> 2.8) | ||
| algoliasearch (~> 1.0) | ||
| concurrent-ruby (~> 1.1) | ||
| fuzzy_match (~> 2.0.4) | ||
| nap (~> 1.0) | ||
| netrc (~> 0.11) | ||
| public_suffix (~> 4.0) | ||
| typhoeus (~> 1.0) | ||
| cocoapods-deintegrate (1.0.5) | ||
| cocoapods-downloader (2.1) | ||
| cocoapods-plugins (1.0.0) | ||
| nap | ||
| cocoapods-search (1.0.1) | ||
| cocoapods-trunk (1.6.0) | ||
| nap (>= 0.8, < 2.0) | ||
| netrc (~> 0.11) | ||
| cocoapods-try (1.2.0) | ||
| colored2 (3.1.2) | ||
| concurrent-ruby (1.3.3) | ||
| drb (2.2.3) | ||
| escape (0.0.4) | ||
| ethon (0.15.0) | ||
| ffi (>= 1.15.0) | ||
| ffi (1.17.2) | ||
| fourflusher (2.3.1) | ||
| fuzzy_match (2.0.4) | ||
| gh_inspector (1.1.3) | ||
| httpclient (2.9.0) | ||
| mutex_m | ||
| i18n (1.14.7) | ||
| concurrent-ruby (~> 1.0) | ||
| json (2.7.6) | ||
| logger (1.7.0) | ||
| minitest (6.0.6) | ||
| drb (~> 2.0) | ||
| prism (~> 1.5) | ||
| molinillo (0.8.0) | ||
| mutex_m (0.3.0) | ||
| nanaimo (0.3.0) | ||
| nap (1.1.0) | ||
| netrc (0.11.0) | ||
| nkf (0.2.0) | ||
| prism (1.9.0) | ||
| public_suffix (4.0.7) | ||
| rexml (3.4.2) | ||
| ruby-macho (2.5.1) | ||
| typhoeus (1.5.0) | ||
| ethon (>= 0.9.0, < 0.16.0) | ||
| tzinfo (2.0.6) | ||
| concurrent-ruby (~> 1.0) | ||
| xcodeproj (1.25.1) | ||
| CFPropertyList (>= 2.3.3, < 4.0) | ||
| atomos (~> 0.1.3) | ||
| claide (>= 1.0.2, < 2.0) | ||
| colored2 (~> 3.1) | ||
| nanaimo (~> 0.3.0) | ||
| rexml (>= 3.3.6, < 4.0) | ||
| zeitwerk (2.6.18) | ||
|
|
||
| PLATFORMS | ||
| ruby | ||
|
|
||
| DEPENDENCIES | ||
| activesupport (>= 6.1.7.5, != 7.1.0) | ||
| benchmark | ||
| bigdecimal | ||
| cocoapods (>= 1.13, != 1.15.1, != 1.15.0) | ||
| concurrent-ruby (< 1.3.4) | ||
| logger | ||
| mutex_m | ||
| xcodeproj (< 1.26.0) | ||
|
|
||
| RUBY VERSION | ||
| ruby 3.2.2p53 | ||
|
|
||
| BUNDLED WITH | ||
| 2.4.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ First, make sure you go through the setup from the main [README](../README.md). | |
|
|
||
| `pod install` | ||
|
|
||
| Note: This example app requires React Native's new architecture and uses dynamic framework linkage, both configured in the Podfile. Open `SampleApp.xcworkspace` in Xcode after installing pods. | ||
|
|
||
| 2. Copy the `Keys.plist.sample` file located in `example/ios/SampleApp/` to a new file named `Keys.plist`. This file is git ignored and won't be accidentally committed. In your Google cloud console, add the Google API key to the project and add this newly created API key to the `Keys.plist` file. | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,11 +23,7 @@ setup_permissions([ | |
| 'Notifications', | ||
| ]) | ||
|
|
||
| use_frameworks! :linkage => :dynamic | ||
|
Contributor
There was a problem hiding this comment. If we do not read the USE_FRAMEWORKS env parameter anymore, we should not pass it in the ci.yml? |
||
|
|
||
| config = use_native_modules! | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,12 +8,9 @@ | |
|
|
||
| /* Begin PBXBuildFile section */ | ||
| 00E356F31AD99517003FC87E /* SampleAppTests.mm in Sources */ = {isa = PBXBuildFile; fileRef = 00E356F21AD99517003FC87E /* SampleAppTests.mm */; }; | ||
| 13B07FBF1A68108700A75B9A /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 13B07FB51A68108700A75B9A /* Images.xcassets */; }; | ||
| 13B07FC11A68108700A75B9A /* main.mm in Sources */ = {isa = PBXBuildFile; fileRef = 13B07FB71A68108700A75B9A /* main.mm */; }; | ||
| 2A20E8122C8994DB00DB7ADA /* main.mm in Sources */ = {isa = PBXBuildFile; fileRef = 13B07FB71A68108700A75B9A /* main.mm */; }; | ||
| 2A20E8282C899A1400DB7ADA /* Info-CarPlay.plist in Resources */ = {isa = PBXBuildFile; fileRef = 13B07FB61A68108700A75B9A /* Info-CarPlay.plist */; }; | ||
| 2AB8C27A2C89A07000250560 /* Keys.plist in Resources */ = {isa = PBXBuildFile; fileRef = 52D4271C2C81D3F300C7FB36 /* Keys.plist */; }; | ||
| 2AB8C27E2C89A0B400250560 /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 81AB9BB72411601600AC10FF /* LaunchScreen.storyboard */; }; | ||
|
|
@@ -25,8 +22,10 @@ | |
| 52206E862C8B2FEC00B34D22 /* PhoneSceneDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 52206E822C8B2FEC00B34D22 /* PhoneSceneDelegate.mm */; }; | ||
| 52206E892C8B303700B34D22 /* AppDelegateCarPlay.mm in Sources */ = {isa = PBXBuildFile; fileRef = 52206E882C8B303700B34D22 /* AppDelegateCarPlay.mm */; }; | ||
| 52D4271D2C81D3F300C7FB36 /* Keys.plist in Resources */ = {isa = PBXBuildFile; fileRef = 52D4271C2C81D3F300C7FB36 /* Keys.plist */; }; | ||
| 64D1697D489B0F3255985321 /* Pods_SampleAppCarPlay.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 95931FFADA3D5522923A0F5B /* Pods_SampleAppCarPlay.framework */; }; | ||
| 81AB9BB82411601600AC10FF /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 81AB9BB72411601600AC10FF /* LaunchScreen.storyboard */; }; | ||
| AA3CA297C8EC7B693A13A44B /* Pods_SampleAppTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 33E9EBE1CFC402F90D5DE484 /* Pods_SampleAppTests.framework */; }; | ||
| C89FA619825746794A19ACB5 /* Pods_SampleApp.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = B0D6ABF2B0017DFBAB6F7A58 /* Pods_SampleApp.framework */; }; | ||
| /* End PBXBuildFile section */ | ||
|
|
||
| /* Begin PBXContainerItemProxy section */ | ||
|
|
@@ -51,8 +50,7 @@ | |
| 2A20E8202C8994DB00DB7ADA /* SampleApp.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = SampleApp.app; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| 2AB8C27C2C89A09D00250560 /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = Info.plist; path = SampleApp/Info.plist; sourceTree = "<group>"; }; | ||
| 2AEB719D2C7C80F9002224A5 /* SampleApp.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; name = SampleApp.entitlements; path = SampleApp/SampleApp.entitlements; sourceTree = "<group>"; }; | ||
| 33E9EBE1CFC402F90D5DE484 /* Pods_SampleAppTests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_SampleAppTests.framework; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| 3B4392A12AC88292D35C810B /* Pods-SampleApp.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-SampleApp.debug.xcconfig"; path = "Target Support Files/Pods-SampleApp/Pods-SampleApp.debug.xcconfig"; sourceTree = "<group>"; }; | ||
| 4735EA9AB0E8831D741A3A3E /* Pods-SampleAppCarPlay.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-SampleAppCarPlay.debug.xcconfig"; path = "Target Support Files/Pods-SampleAppCarPlay/Pods-SampleAppCarPlay.debug.xcconfig"; sourceTree = "<group>"; }; | ||
| 5205C1212C8B314F00D0FC6B /* AppDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = AppDelegate.mm; path = SampleApp/AppDelegate.mm; sourceTree = "<group>"; }; | ||
|
|
@@ -70,34 +68,34 @@ | |
| 750C10660A3F190F6072C5DA /* Pods-SampleAppCarPlay.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-SampleAppCarPlay.release.xcconfig"; path = "Target Support Files/Pods-SampleAppCarPlay/Pods-SampleAppCarPlay.release.xcconfig"; sourceTree = "<group>"; }; | ||
| 81AB9BB72411601600AC10FF /* LaunchScreen.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; name = LaunchScreen.storyboard; path = SampleApp/LaunchScreen.storyboard; sourceTree = "<group>"; }; | ||
| 89C6BE57DB24E9ADA2F236DE /* Pods-SampleApp-SampleAppTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-SampleApp-SampleAppTests.release.xcconfig"; path = "Target Support Files/Pods-SampleApp-SampleAppTests/Pods-SampleApp-SampleAppTests.release.xcconfig"; sourceTree = "<group>"; }; | ||
| 95931FFADA3D5522923A0F5B /* Pods_SampleAppCarPlay.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_SampleAppCarPlay.framework; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| A9D547919643FC330CF84EC3 /* Pods-SampleAppTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-SampleAppTests.release.xcconfig"; path = "Target Support Files/Pods-SampleAppTests/Pods-SampleAppTests.release.xcconfig"; sourceTree = "<group>"; }; | ||
| B0D6ABF2B0017DFBAB6F7A58 /* Pods_SampleApp.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_SampleApp.framework; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| ED297162215061F000B7C4FE /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = System/Library/Frameworks/JavaScriptCore.framework; sourceTree = SDKROOT; }; | ||
| /* End PBXFileReference section */ | ||
|
|
||
| /* Begin PBXFrameworksBuildPhase section */ | ||
| 00E356EB1AD99517003FC87E /* Frameworks */ = { | ||
| isa = PBXFrameworksBuildPhase; | ||
| buildActionMask = 2147483647; | ||
| files = ( | ||
| AA3CA297C8EC7B693A13A44B /* Pods_SampleAppTests.framework in Frameworks */, | ||
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| }; | ||
| 13B07F8C1A680F5B00A75B9A /* Frameworks */ = { | ||
| isa = PBXFrameworksBuildPhase; | ||
| buildActionMask = 2147483647; | ||
| files = ( | ||
| 64D1697D489B0F3255985321 /* Pods_SampleAppCarPlay.framework in Frameworks */, | ||
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| }; | ||
| 2A20E8132C8994DB00DB7ADA /* Frameworks */ = { | ||
| isa = PBXFrameworksBuildPhase; | ||
| buildActionMask = 2147483647; | ||
| files = ( | ||
| C89FA619825746794A19ACB5 /* Pods_SampleApp.framework in Frameworks */, | ||
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| }; | ||
|
|
@@ -148,9 +146,9 @@ | |
| isa = PBXGroup; | ||
| children = ( | ||
| ED297162215061F000B7C4FE /* JavaScriptCore.framework */, | ||
| B0D6ABF2B0017DFBAB6F7A58 /* Pods_SampleApp.framework */, | ||
| 95931FFADA3D5522923A0F5B /* Pods_SampleAppCarPlay.framework */, | ||
| 33E9EBE1CFC402F90D5DE484 /* Pods_SampleAppTests.framework */, | ||
| ); | ||
| name = Frameworks; | ||
| sourceTree = "<group>"; | ||
|
|
@@ -806,6 +804,22 @@ | |
| GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | ||
| GCC_WARN_UNUSED_FUNCTION = YES; | ||
| GCC_WARN_UNUSED_VARIABLE = YES; | ||
| HEADER_SEARCH_PATHS = ( | ||
| "$(inherited)", | ||
| "${PODS_ROOT}/ReactCommon", | ||
| "${PODS_ROOT}/ReactCommon/react/nativemodule/core", | ||
| "${PODS_ROOT}/React-runtimeexecutor", | ||
| "${PODS_ROOT}/React-runtimeexecutor/platform/ios", | ||
| "${PODS_ROOT}/ReactCommon-Samples", | ||
| "${PODS_ROOT}/ReactCommon-Samples/platform/ios", | ||
| "${PODS_ROOT}/React-Fabric/react/renderer/components/view/platform/cxx", | ||
| "${PODS_ROOT}/React-NativeModulesApple", | ||
| "${PODS_ROOT}/React-bridging", | ||
| "${PODS_ROOT}/React-graphics", | ||
| "${PODS_ROOT}/React-graphics/react/renderer/graphics/platform/ios", | ||
| "${PODS_ROOT}/React-featureflags", | ||
| "${PODS_ROOT}/React-renderercss", | ||
| ); | ||
| IPHONEOS_DEPLOYMENT_TARGET = 16.6; | ||
| LD_RUNPATH_SEARCH_PATHS = ( | ||
| /usr/lib/swift, | ||
|
|
@@ -881,6 +895,22 @@ | |
| GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | ||
| GCC_WARN_UNUSED_FUNCTION = YES; | ||
| GCC_WARN_UNUSED_VARIABLE = YES; | ||
| HEADER_SEARCH_PATHS = ( | ||
| "$(inherited)", | ||
| "${PODS_ROOT}/ReactCommon", | ||
| "${PODS_ROOT}/ReactCommon/react/nativemodule/core", | ||
| "${PODS_ROOT}/React-runtimeexecutor", | ||
| "${PODS_ROOT}/React-runtimeexecutor/platform/ios", | ||
| "${PODS_ROOT}/ReactCommon-Samples", | ||
| "${PODS_ROOT}/ReactCommon-Samples/platform/ios", | ||
| "${PODS_ROOT}/React-Fabric/react/renderer/components/view/platform/cxx", | ||
| "${PODS_ROOT}/React-NativeModulesApple", | ||
| "${PODS_ROOT}/React-bridging", | ||
| "${PODS_ROOT}/React-graphics", | ||
| "${PODS_ROOT}/React-graphics/react/renderer/graphics/platform/ios", | ||
| "${PODS_ROOT}/React-featureflags", | ||
| "${PODS_ROOT}/React-renderercss", | ||
| ); | ||
| IPHONEOS_DEPLOYMENT_TARGET = 16.6; | ||
| LD_RUNPATH_SEARCH_PATHS = ( | ||
| /usr/lib/swift, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using this USE_FRAMEWORKS env variable is removed from the podfile. Should we remove this from here as well.