Show complete proposal summaries in uniform cards - #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Proposal cards shortened summary strings in JavaScript and then clipped them to one CSS line. Complete descriptions such as the Ember proposal were therefore invisible, while allowing unrestricted wrapping would make card heights inconsistent.
What changed
GlassyRecordCardBecause this is implemented in the shared record card, proposal lists, chamber records, Feed records, and public drafts use the same behavior.
Validation
yarn test- 54 files, 240 tests passedyarn typecheckyarn buildgit diff --checkData safety
Web-only presentation change. No API contract, migration, runtime mock wiring, production data, or preview artifact is included.