Skip to content

Fix: the GPS timeout ignores what the protocol asks for, so some receivers are never configured #11977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrScothh wants to merge 1 commit into
base: maintenance-10.x
Choose a base branch
from
+3 −2
Open

Fix: the GPS timeout ignores what the protocol asks for, so some receivers are never configured #11977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/io/gps.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,9 @@ bool gpsUpdate(void)
// Call GPS protocol thread
gpsProviders[gpsState.gpsConfig->provider].protocol();

// Check for GPS timeout
if ((millis() - gpsState.lastMessageMs) > gpsState.baseTimeoutMs) {
// Check for GPS timeout. The protocol may ask for longer while it sets the
// receiver up, during autobaud or detection, but never gets less than the base
if ((millis() - gpsState.lastMessageMs) > MAX(gpsState.timeoutMs, gpsState.baseTimeoutMs)) {
sensorsClear(SENSOR_GPS);
DISABLE_STATE(GPS_FIX);
gpsSol.fixType = GPS_NO_FIX;
Expand Down
Loading