Conversation
The command is defined in msp_protocol_v2_inav.h and answered in fc_msp.c, but the registry never listed it, so check_msp.py fails on maintenance-10.x and on every pull request that runs the MSP consistency workflow.
MSP2_INAV_ESC_SRXL2_STATUS and MSP2_INAV_ESC_SRXL2_CALIBRATE came in with iNavFlight#11947 without an entry in msp_messages.json, which is two of the three commands check_msp.py reports as missing.
Contributor
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can keep summaries lean with Finding overflow, which tucks the rest behind 'View more' |
PR Summary by QodoRegister missing MAG and SRXL2 MSP commands
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
check_msp.pyfails onmaintenance-10.x, so the MSP consistency workflow goes red on every pull request that touches MSP, whatever the pull request does. Three commands are defined inmsp_protocol_v2_inav.hand answered infc_msp.cbut have no entry inmsp_messages.json:MSP2_INAV_ESC_SRXL2_STATUS(0x2233) andMSP2_INAV_ESC_SRXL2_CALIBRATE(0x2234), which came in with my Spektrum Smart ESC (SRXL2) motor output #11947 and which I should have added then;MSP2_INAV_MAG_UNALIGNED(0x2232), which isn't mine, but without it the check stays red.What I changed
An entry for each, written from the handlers in
fc_msp.cand the enums inmotor_srxl2.h, withREADME.mdregenerated bygen_msp_docs.sh. TheMAG_UNALIGNEDentry is a commit of its own, so it can be dropped if its author would rather write it.The registry version goes from 2.1.1 to 2.1.2: new entries inside the current schema, which the versioning rule counts as a patch.
Testing
check_msp.pypasses ("281 C definitions match 282 JSON definitions"), andgen_msp_docs.shleavesREADME.mdunchanged after the commit, which is what the workflow compares.#11979 also bumps the registry version, so whichever of the two goes in second will need that line rebased.