Conversation
Change the way lexical models are loaded on Android to attempt to work around an apparent bug in Chrome on Android, where calls to `global.importScripts()` fail with a rather strange 'NetworkError' -- given the files are local. This patch is designed to be relatively easy to cleanup in the future if the underlying issue is addressed. Note that this depends on unbundling the worker so is not easily ported to 18.0-stable as it stands; we'd need to rework this for 18.0. Relates-to: #13862
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions
Results TemplateTest Artifacts
|
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
This was referenced Sep 18, 2026
Merged
Member
Author
|
Per #13862 (comment), this should not be needed. The move to the WebView asset loader approach addressed the issue from another direction, which is cleaner. Recommend continuing with the unbundling of the lexical model worker, for other reasons, but that does not necessarily need to be merged in 19.0. |
mcdurdin
deleted the
fix/android/13862-concatenated-worker-and-model
branch
September 22, 2026 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the way lexical models are loaded on Android to attempt to work around an apparent bug in Chrome on Android, where calls to
global.importScripts()fail with a rather strange 'NetworkError' -- given the files are local.This patch is designed to be relatively easy to cleanup in the future if the underlying issue is addressed.
Note that this depends on unbundling the worker so is not easily ported to 18.0-stable as it stands; we'd need to rework this for 18.0.
Relates-to: #13862
User Testing
TEST_ANDROID_MODEL: In Keyman for Android, install a keyboard for a language that includes a lexical model. Verify that the suggestions appear as normal and no error toasts are presented. Switch between the English keyboard and the new keyboard and verify that predictions keep working after switches. Install a keyboard that does not have a lexical model. Verify that it works and suggestions are not offered. Uninstall the first keyboard and reinstall it.
TEST_IOS_MODEL: In Keyman for iOS, install a keyboard for a language that includes a lexical model. Verify that the suggestions appear as normal and no error toasts are presented. Switch between the English keyboard and the new keyboard and verify that predictions keep working after switches. Install a keyboard that does not have a lexical model. Verify that it works and suggestions are not offered. Uninstall the first keyboard and reinstall it.
TEST_DEVELOPER_SERVER: Verify that lexical models can be tested in Keyman Developer Server; open Developer Console and verify that no errors are presented.