feat(desktop): native macOS usage panel and release regression fixes - #5490
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (136)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 58 / 80이 PR은 맥 트레이의 사용량 창을 웹뷰 대신, 지금 돌아가는 Tauri 프로세스 안의 AppKit 패널(SwiftUI)로 바꿉니다. 네트워크와 계정 정보는 러스트가 읽고, 스위프트에는 보여 주기용 JSON만 넘깁니다. 윈도·리눅스는 예전 웹 팝업을 유지하되 안쪽만 스크롤되게 맞춥니다. 같은 필터 규칙이 트레이 제목, 위젯, 웹 컴패니언에도 쓰이게 맞춰져 있습니다. 베이스는 여기에 업데이트 소유권 임대(
메인테이너의 판단이 필요한 지점 네이티브 트레이와 업데이트·모델 이름·CI 격리·문서가 한 PR에 묶여 있습니다. 초안 설명도 소스 리뷰·exact-head CI가 남아 있다고 합니다. 트레이만 먼저 나눌지, 회귀 묶음을 그대로 갈지 정해 주세요. 너의 추천 초안인 채로 두세요. 먼저 이 댓글은 grok-bot이 작성했습니다 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d64bd3040
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
The native presentation follows the former companion mechanism from commit 38a5ab9 (#5196); it does not restore a second application or runtime owner.
Verification
devlog/_plan/260922_native_tray_release/021_integration_verification.mdand031_verification.md; it is not a substitute for final exact-head hosted CI.3d64bd3040b2da7953962da3c05be14f31991e56: PR CI, all-platform dispatch including Windows and macOS control, and service lifecycle PR CI and service lifecycle passed; the all-platform dispatch is still completing its final macOS jobs. Earlier failures are preserved in 031_verification.md and drove the follow-up fixes.Checklist
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Maintainer delivery decision: the repository owner explicitly authorized admin integration into dev after successful required exact-head CI, followed by preview and main stable deployment. This is maintainer integration, not an independent approval. Final merge remains gated on the recorded verification and unresolved review findings.
Summary by CodeRabbit
New Features
Improvements
Documentation