Skip to content

docs(contributor): reconcile landed task rows - #4855

Merged
huangruiteng merged 1 commit into
loopx-project:mainfrom
Duang777:codex/reconcile-landed-contributor-tasks
Sep 21, 2026
Merged

huangruiteng merged 1 commit into
loopx-project:mainfrom
Duang777:codex/reconcile-landed-contributor-tasks

Conversation

@Duang777

Copy link
Copy Markdown
Contributor

Goal And Delivered Outcome

Scope And Continuation

  • Completed scope and remaining work: complete within this scope. No runtime, CLI behavior, protocol, or authority rule changes.
  • Slice boundary / successor: N/A. This PR only reconciles existing public task facts.

Validation

  • Tested revision: 9cf67def8c2aa0c61e73c806883aa0bfaf600402
  • Run state: finished
  • Input classes: public_fixture
Check kind Result Public-safe evidence / limitation
unit passed uv run --extra test python examples/docs-governance-smoke.py
static passed loopx check on both changed paths: 0 errors, 0 warnings; Ruff, Python compile, and diff checks passed.
integration passed Risk-based premerge selected 11 checks; all passed with 0 manual holds.
  • Coverage and gaps: the first premerge attempt failed because the new worktree lacked the TypeScript parser dependencies. After npm ci --ignore-scripts, the semantic-vocabulary smoke and the complete premerge selection passed. Runtime validation is not applicable because this PR changes only contributor metadata and its governance assertion.

Frontend / Visual Evidence

  • UI impact: none
  • Before: N/A
  • After: N/A
  • States and viewports shown: N/A
  • Source data: none
  • Attention review: N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring (no functional changes)
  • Documentation update
  • Test update

LoopX Area

  • Control plane (goals, todos, quota, scheduler, registry, runtime)
  • Benchmark boundary (adapters, runners, verifiers, scoring, evidence)
  • Capability or extension (providers, adapters, skills)
  • Public docs or presentation surface (README, protocols, dashboard)
  • Build, packaging, installer, or CI
  • Host or runtime integration

Technical Direction

  • Direction / acceptance reference, when applicable: Core control-plane hardening, contributor task board accuracy.

Shared-authority RFC fixture impact

N/A. This PR does not claim TypeScript migration or shared-authority progress.

Boundary Checklist

  • Neither the diff nor this PR body/comments/attachments disclose private state, credentials, raw traces or verifier output, internal links, or local machine paths.
  • I did not duplicate maintainer-owned benchmark work unless a maintainer split out a public issue for it.
  • I kept the change scoped to the linked task rows.
  • I marked UI impact none.
  • Every commit includes a DCO Signed-off-by trailer.

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
@Duang777

Copy link
Copy Markdown
Contributor Author

@huangruiteng 请审阅这次任务板事实同步。它只更新 GH-C06 与 GH-C100 的已合入状态及 docs-governance 防回退断言;exact head 9cf67def8c2aa0c61e73c806883aa0bfaf600402 的本地 premerge 11/11 通过,0 manual holds。当前账号没有 RequestReviewsByLogin 权限,因此在评论中请求审阅。

@Duang777

Copy link
Copy Markdown
Contributor Author

CI triage: the four Python shard failures are inherited main regressions already fixed by merged #4847 plus #4833. The remaining node-minimum-compatibility failure is the mixed-provider test running SQLite on unqualified Node 22.18; the focused fix is #4857. I will merge current main into this branch after #4857 lands, then rerun the exact head. No docs change is implicated.

@Job28703

Copy link
Copy Markdown

Independent review of exact head 9cf67def8c2aa0c61e73c806883aa0bfaf600402 (adversarial review chain, reviewer PASS after two revision rounds):

Verdict: APPROVE.

Every new status claim traces to a merged PR and file evidence: #4659 (09-17, support_control{,_update}.py = update owner), #4803 (09-21, goal_channel_operation.py = prepare/deliver owner), #4818 (09-21, quota_action_selection.py), #4422 (09-15, sole-file test_coordination_provider_parity.py with all five claimed scenarios present at :165/:178/:194/:223/:240). I mechanically replayed the five new governance-smoke assertions (2 required + 3 stale) against the head file under the smoke's compact() semantics — all green.

Scope note, not a blocker: three same-shape stale rows remain on the board (GH-C02 still says #4436 (open) but it merged 09-15; GH-C70 "Claimed: PR #3664" merged 09-04; GH-C89 "Claimed: PR #4172" merged 09-11). Worth a small follow-up PR so "board is current" fully holds.

@huangruiteng huangruiteng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

动机

这次修复的目标成立:公开 contributor board 仍把已经合并的工作写成进行中或待实现,会诱导重复认领。已逐项核验 #4659#4803#4818#4422 均已合并,因此把 GH-C06 与 GH-C100 改成 landed/done 是对当前事实的修正;它没有声称同时清理所有其它历史行。

改动思路

改动沿用现有权威边界,没有引入新的同步状态:GitHub 合并状态提供事实,docs/development/contributor-tasks.md 负责公开投影,既有 assert_contributor_task_board_is_current 负责防止这两行退回旧文本。与另建一次性 smoke 相比,在现有聚合检查中同时加入新文本和 stale 文本断言更小,也更容易长期维护。

具体改动

关键内容讲解

  • GH-C06 的摘要从只指向 #4803In review 改为列出 #4659#4803#4818Done,详细行也分别说明三块 CLI owner 已落地。
  • GH-C100 从未来式的“characterize”改成 #4422 已交付的 provider-neutral parity fixture,并保留对应的聚焦验证命令。
  • docs governance smoke 新增两条 required 文本与三条 stale 文本,确保本次纠正不会静默回退;没有创建重复 smoke。

对主干的风险

内容风险较低:精确 head 9cf67def8c2aa0c61e73c806883aa0bfaf600402docs-governance-smoke、两条触达路径的 loopx checkgit diff --check 均通过;把当前 origin/main 以 no-commit 方式合入后,冲突检查和相同验证也通过。

但当前 exact head 仍落后主干,远端最终 CI 不是绿色:node-minimum-compatibility、四个 test shard、pytestmerge-gate 均为失败。packet 明确要求 repository-native local validation 和最终 CI;本地聚焦验证不能替代这一份 exact-head 远端收据。最小修复是 rebase 到当前 main、保持这份窄 diff,再让 required checks 全部跑绿。

我的整体评价

文档事实、作用边界和 smoke 放置都正确,且 current-main 合入后的聚焦验证通过;我没有发现代码/文案层面的额外 blocker。当前唯一 blocker 是 exact head 缺少成功的最终 CI,因此本轮先请求修改,rebase 后无需扩 scope,直接按新 head 重跑即可复审。

English verdict: REQUEST_CHANGES - head 9cf67de has correct focused content and passes focused plus current-main integration validation, but it is behind main and lacks the required successful final CI; rebase the unchanged narrow patch and rerun all required checks.

@huangruiteng
huangruiteng merged commit 0ce8092 into loopx-project:main Sep 21, 2026
17 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants