docs(contributor): reconcile landed task rows - #4855
huangruiteng merged 1 commit into
Conversation
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
|
@huangruiteng 请审阅这次任务板事实同步。它只更新 GH-C06 与 GH-C100 的已合入状态及 docs-governance 防回退断言;exact head |
|
CI triage: the four Python shard failures are inherited main regressions already fixed by merged #4847 plus #4833. The remaining |
|
Independent review of exact head Verdict: APPROVE. Every new status claim traces to a merged PR and file evidence: #4659 (09-17, Scope note, not a blocker: three same-shape stale rows remain on the board (GH-C02 still says |
huangruiteng
left a comment
There was a problem hiding this comment.
动机
这次修复的目标成立:公开 contributor board 仍把已经合并的工作写成进行中或待实现,会诱导重复认领。已逐项核验 #4659、#4803、#4818、#4422 均已合并,因此把 GH-C06 与 GH-C100 改成 landed/done 是对当前事实的修正;它没有声称同时清理所有其它历史行。
改动思路
改动沿用现有权威边界,没有引入新的同步状态:GitHub 合并状态提供事实,docs/development/contributor-tasks.md 负责公开投影,既有 assert_contributor_task_board_is_current 负责防止这两行退回旧文本。与另建一次性 smoke 相比,在现有聚合检查中同时加入新文本和 stale 文本断言更小,也更容易长期维护。
具体改动
关键内容讲解
- GH-C06 的摘要从只指向 #4803 的
In review改为列出 #4659、#4803、#4818 的Done,详细行也分别说明三块 CLI owner 已落地。 - GH-C100 从未来式的“characterize”改成 #4422 已交付的 provider-neutral parity fixture,并保留对应的聚焦验证命令。
- docs governance smoke 新增两条 required 文本与三条 stale 文本,确保本次纠正不会静默回退;没有创建重复 smoke。
对主干的风险
内容风险较低:精确 head 9cf67def8c2aa0c61e73c806883aa0bfaf600402 上 docs-governance-smoke、两条触达路径的 loopx check 与 git diff --check 均通过;把当前 origin/main 以 no-commit 方式合入后,冲突检查和相同验证也通过。
但当前 exact head 仍落后主干,远端最终 CI 不是绿色:node-minimum-compatibility、四个 test shard、pytest 与 merge-gate 均为失败。packet 明确要求 repository-native local validation 和最终 CI;本地聚焦验证不能替代这一份 exact-head 远端收据。最小修复是 rebase 到当前 main、保持这份窄 diff,再让 required checks 全部跑绿。
我的整体评价
文档事实、作用边界和 smoke 放置都正确,且 current-main 合入后的聚焦验证通过;我没有发现代码/文案层面的额外 blocker。当前唯一 blocker 是 exact head 缺少成功的最终 CI,因此本轮先请求修改,rebase 后无需扩 scope,直接按新 head 重跑即可复审。
English verdict: REQUEST_CHANGES - head 9cf67de has correct focused content and passes focused plus current-main integration validation, but it is behind main and lacks the required successful final CI; rebase the unchanged narrow patch and rerun all required checks.
Goal And Delivered Outcome
mainat855c8ca0d.Scope And Continuation
Validation
9cf67def8c2aa0c61e73c806883aa0bfaf600402unitpasseduv run --extra test python examples/docs-governance-smoke.pystaticpassedloopx checkon both changed paths: 0 errors, 0 warnings; Ruff, Python compile, and diff checks passed.integrationpassednpm ci --ignore-scripts, the semantic-vocabulary smoke and the complete premerge selection passed. Runtime validation is not applicable because this PR changes only contributor metadata and its governance assertion.Frontend / Visual Evidence
Type of Change
LoopX Area
Technical Direction
Shared-authority RFC fixture impact
N/A. This PR does not claim TypeScript migration or shared-authority progress.
Boundary Checklist
none.Signed-off-bytrailer.