Skip to content

test(ci): qualify lease inspection on public Node - #4857

Open
Duang777 wants to merge 1 commit into
loopx-project:mainfrom
Duang777:codex/qualify-task-lease-inspection-public-node
Open

Duang777 wants to merge 1 commit into
loopx-project:mainfrom
Duang777:codex/qualify-task-lease-inspection-public-node

Conversation

@Duang777

Copy link
Copy Markdown
Contributor

Summary

  • Skip only the SQLite variants in the mixed task-lease inspection suite when the current Node/SQLite pair is not qualified.
  • Keep the legacy and File authority variants running on the public minimum Node, while qualified runtimes continue to exercise SQLite.

Root cause

task_lease_inspection.test.ts was added to the public-minimum suite with File, SQLite, and PostgreSQL variants. Node 22.18.0 embeds SQLite 3.50.2, which the authority boundary correctly rejects because it lacks the required WAL-reset fix. The test did not apply the runtime-qualified SQLite skip already used by adjacent mixed-provider suites, so node-minimum-compatibility failed independently of the PR under test. This was observed on #4855.

Validation

  • Before the fix on Node 22.18.0: 8 passed, 2 failed, 2 skipped.
  • After the fix on Node 22.18.0: 8 passed, 0 failed, 4 skipped.
  • On qualified Node 24.16.0: 10 passed, 0 failed, 2 PostgreSQL-only skips.
  • Exact public-minimum CI command: 2,038 tests, 2,018 passed, 20 skipped, 0 failed.
  • npm run typecheck:control-plane passed on Node 22.18.0.
  • loopx canary premerge --from-git-diff: 4/4 passed, 0 manual holds.
  • git diff --check passed.

This changes test qualification only; production authority admission remains fail-closed.

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
@Duang777

Copy link
Copy Markdown
Contributor Author

Exact-head status for 1acf90d895f42e50a1d352a4dda9fa5e9bb589b0: the Node minimum and forward compatibility checks pass. The sole completed failure, test-shard (2), reproduces unchanged on current main@59e11118f because a project-lifecycle test fixture lacks the settlement progress contract added by #4852. #4859 contains the isolated fixture repair; no #4857 code change is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant