PYTHON-6003 Fix flaky test_pool_unpause - #2983
Open
blink1073 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The default streaming SDAM protocol starts a separate RTT monitor that issues its own hello calls with the same appName, racing against the test's failCommand (mode.times=2) for the SDAM heartbeat monitor's own hello calls. When the RTT monitor's hello wins the race, the SDAM monitor never sees a failure and ServerHeartbeatFailedEvent never fires. Force serverMonitoringMode="poll" to remove the RTT monitor and the race.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes flakiness in the test_pool_unpause integration test by preventing the streaming SDAM RTT monitor from racing the test’s failCommand budget, ensuring ServerHeartbeatFailedEvent reliably fires.
Changes:
- Forces
serverMonitoringMode="poll"intest_pool_unpauseto disable the RTT monitor and remove thehellorace. - Adds an explanatory comment describing why polling is required for test stability (PYTHON-6003).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/asynchronous/test_discovery_and_monitoring.py | Forces polling monitoring mode in the async test_pool_unpause to eliminate RTT-monitor hello interference. |
| test/test_discovery_and_monitoring.py | Sync mirror of the same test adjustment (generated counterpart). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6003
Changes in this PR
test_pool_unpauseflaked because the default streaming SDAM protocol starts an RTT monitor that sends its ownhellocalls with the sameappName, racing the test'sfailCommand(mode.times: 2) against the SDAM heartbeat monitor'shellocalls. When the RTT monitor won the race,ServerHeartbeatFailedEventnever fired and the test timed out.Fix: pass
serverMonitoringMode="poll"to disable the RTT monitor and remove the race.Test Plan
test_pool_unpauseagainst a local MongoDB 8.0 server 15 times: reproduced the failure twice.just lintandjust typingpass.Checklist
Checklist for Author
Checklist for Reviewer