Skip to content

PYTHON-6003 Fix flaky test_pool_unpause #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blink1073 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PYTHON-6003 Fix flaky test_pool_unpause #2983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10069fd
PYTHON-6003 Fix flaky test_pool_unpause
blink1073 Aug 13, 2026
fac2e35
PYTHON-6003 Clarify race condition wording in test_pool_unpause comment
blink1073 Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/asynchronous/test_discovery_and_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,14 @@ class TestPoolManagement(AsyncIntegrationTest):
async def test_pool_unpause(self):
# This test implements the prose test "AsyncConnection Pool Management"
listener = CMAPHeartbeatListener()
# Force polling: streaming's RTT monitor sends its own hello calls with the same
# appName, which can consume the failCommand's mode.times budget before the SDAM
# heartbeat monitor's hello does, so ServerHeartbeatFailedEvent never fires (PYTHON-6003).
_ = await self.async_single_client(
appName="SDAMPoolManagementTest", heartbeatFrequencyMS=500, event_listeners=[listener]
appName="SDAMPoolManagementTest",
heartbeatFrequencyMS=500,
event_listeners=[listener],
serverMonitoringMode="poll",
)
# Assert that AsyncConnectionPoolReadyEvent occurs after the first
# ServerHeartbeatSucceededEvent.
Expand Down
8 changes: 7 additions & 1 deletion test/test_discovery_and_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,14 @@ class TestPoolManagement(IntegrationTest):
def test_pool_unpause(self):
# This test implements the prose test "Connection Pool Management"
listener = CMAPHeartbeatListener()
# Force polling: streaming's RTT monitor sends its own hello calls with the same
# appName, which can consume the failCommand's mode.times budget before the SDAM
# heartbeat monitor's hello does, so ServerHeartbeatFailedEvent never fires (PYTHON-6003).
_ = self.single_client(
appName="SDAMPoolManagementTest", heartbeatFrequencyMS=500, event_listeners=[listener]
appName="SDAMPoolManagementTest",
heartbeatFrequencyMS=500,
event_listeners=[listener],
serverMonitoringMode="poll",
)
# Assert that ConnectionPoolReadyEvent occurs after the first
# ServerHeartbeatSucceededEvent.
Expand Down
Loading