Skip to content

CI: test composite change detection action - #12898

Draft
adamrtalbot wants to merge 2 commits into
nf-core:masterfrom
adamrtalbot:ci/detect-nf-test-changes-composite
Draft

CI: test composite change detection action#12898
adamrtalbot wants to merge 2 commits into
nf-core:masterfrom
adamrtalbot:ci/detect-nf-test-changes-composite

Conversation

@adamrtalbot

@adamrtalbot adamrtalbot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Why

The pinned detect-nf-test-changes v0.0.6 action cannot build because its Debian Bullseye base can no longer install Git. This draft tests the replacement uv-backed composite action without changing the existing workflow behaviour.

Related to #12893. This is an alternative to #12897; the two PRs should not both be merged.

What

  • Update all three CPU and GPU workflow references to the tested composite-action commit
  • Keep the action pinned to a full immutable SHA
  • Add temporary comment-only changes to CPU and GPU modules to exercise non-empty detection outputs

Before marking ready

  • Release the composite version of adamrtalbot/detect-nf-test-changes
  • Replace the temporary commit reference and comment with the released version's immutable SHA
  • Remove the temporary comments from samtools/sort and parabricks/dbsnp
  • Confirm all nf-core/modules CI checks pass

PR checklist

  • This comment contains a description of changes with the reason.
  • The changed files pass repository formatting and validation hooks.
  • Remove all TODO statements.

Test the uv-backed action in the CPU and GPU change-detection jobs.
Keep the PR in draft until the action has a released immutable SHA.

Constraint: Preserve the existing workflow inputs
Confidence: high
Scope-risk: narrow
Add comment-only module changes so the draft exercises non-empty outputs
through both change-detection jobs. Remove these before marking it ready.

Constraint: Do not change module behaviour
Confidence: high
Scope-risk: narrow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant