build: add simdutf dir to include path in GN build - #65382
Open
codebytere wants to merge 1 commit into
Open
Conversation
anonrig
approved these changes
Aug 18, 2026
The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
force-pushed
the
build-gn-simdutf-include
branch
from
August 18, 2026 14:48
64cd05c to
857e40c
Compare
codebytere
added
embedding
github-actions
Bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Aug 18, 2026
Collaborator
codebytere
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GN build defaults
node_simdutf_pathto//third_party/simdutf, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path (Chromium code includes it asthird_party/simdutf/simdutf.h), so the unqualified#include "simdutf.h"in libnode,node_js2candnode_cctestdoesn't resolve unless the embedder adds the directory themselves.This adds
get_label_info(node_simdutf_path, "dir")tonode_internal_config, which libnode andnode_cctestalready use, and tonode_js2c'sinclude_dirs.get_label_inforather than the raw string so a value like//foo/bar:simdutfstill resolves to a directory.There's no GN CI in this repo; i checked this in an embedder build.
Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.