ci: ratchet the role-word baseline for approvals.mdx (5 → 9)#3123
Closed
os-zhuang wants to merge 1 commit into
Closed
ci: ratchet the role-word baseline for approvals.mdx (5 → 9)#3123os-zhuang wants to merge 1 commit into
os-zhuang wants to merge 1 commit into
Conversation
#3113 (docs P1 wave 2) added four `role` mentions to the approvals page and left the ADR-0090 D3 vocabulary ratchet red — main's Lint & Type Check has failed on every commit since. The new occurrences are the class the ratchet's own docstring exempts ("many are legitimate — the better-auth boundary"): they document `sys_member.role` (a real better-auth membership tier) and the `type: 'role'` approver type, precisely to teach authors NOT to put a position name there. That is boundary documentation, not vocabulary drift, so the baseline moves rather than the prose. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
os-zhuang
added
the
skip-changeset
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
作废——role-word baseline 的处置交回 #3113 的作者。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题:main 的 Lint & Type Check 全红
自 #3113(docs P1 wave 2,
25a19be72)起,main 上每一个 commit 的 Lint & Type Check 都因此失败(含之后无辜的 #3111、#3101、#3102、#3108)。该 PR 给 approvals 页加了 4 处role但没同步 ratchet baseline。为什么是上调 baseline 而不是改文案
这 4 处正是
scripts/check-role-word.mjs自己 docstring 里点名豁免的那一类:具体内容:
sys_member.role(owner/admin/member)——better-auth 的真实字段,不是 ADR-0090 D3 要消灭的旧词汇type: 'role'——审批 approver 的真实 spec 枚举值而且这段文字的用途恰恰是教作者别把 position 名写进
type:'role'(还配了os lint规则approval-role-not-membership-tier)。这是边界文档,不是词汇漂移——所以移动 baseline,不动 prose。验证
不在本 PR 范围
main 另有一处红:Publish Smoke。它与本问题无关且不是回归——该门由 #3100 于 4 小时前落地,落地 9 分钟后的第一次运行就失败,在 main 上从未绿过。已另开 issue 记录诊断。
🤖 Generated with Claude Code