feat(platform-objects): surface phone number in create_user result dialog#3261
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 2 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
…alog The create-user response's `user` object carries `phoneNumber` only for phone-based accounts (admin-user-endpoints.ts builds it conditionally). Declaring it is safe now that objectui's ActionResultDialog skips fields whose path is absent from the payload — email-only users see no dirty Phone Number row, and (same mechanism) manually-set passwords no longer render an undefined Temporary Password row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3260
What
Adds
{ path: 'user.phoneNumber', label: 'Phone Number', format: 'text' }tosys_user.create_user'sresultDialog.fields, so an admin creating a phone-based account sees the normalized E.164 sign-in number alongside the email and temporary password. The create-user response buildsuser.phoneNumberconditionally (packages/plugins/plugin-auth/src/admin-user-endpoints.ts) — it exists only for phone-based accounts.Merge order
Depends on objectstack-ai/objectui#2674 (skip resultDialog fields whose path does not resolve). On older objectui, email-only users would get a dirty Phone Number row rendering
undefined— merge the objectui fix first.Verification
@objectstack/platform-objectstests: 213 passed. Changeset included (minor).🤖 Generated with Claude Code