fix(create-objectstack): exclude CHANGELOG.md from the skills-catalog-boundary ratchet (unblocks main Test Core)#3346
Merged
Conversation
…-boundary ratchet (main red) The `no customer-facing surface advertises a repo-root skills install` guard (template-consistency.test.ts) grepped `content/docs`/`skills`/ `packages/create-objectstack` for `skills add objectstack-ai/framework` not followed by `/skills`, excluding only the test file — not CHANGELOG.md. When Changesets versioned create-objectstack in RC mode, it baked #3101's changeset prose into packages/create-objectstack/CHANGELOG.md. That entry documents the fix by quoting the removed command in past tense ("…advertised `skills add objectstack-ai/framework --all` … now scoped to the /skills subpath"), which tripped the ratchet and turned Test Core red on main (pre-existing; first seen at e412fb6 / 631deba, before any of my changes). A CHANGELOG documenting the REMOVAL of an anti-pattern is not advertising it — only real customer-facing surfaces (docs, README, index.ts, AGENTS.md, which all correctly use the /skills subpath) should count. Exclude `**/CHANGELOG.md` from the guard's grep surfaces. Test-only change; no shipped behavior. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 8 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem —
Test Coreis red onmainThe required Test Core gate has been failing on
mainsince before the current head (first seen ate412fb676/631debac5; last green629fbae80). One test fails:create-objectstack › template-consistency.test.ts › skills catalog boundary › no customer-facing surface advertises a repo-root skills installRoot cause
The guard greps
content/docs/skills/packages/create-objectstackforskills add objectstack-ai/frameworknot followed by/skills, excluding only the test file — notCHANGELOG.md.When Changesets versioned
create-objectstackin RC mode, it baked #3101's changeset prose intopackages/create-objectstack/CHANGELOG.md:99. That entry documents the fix by quoting the removed command in past tense:The ratchet flagged that historical quote as a live advertisement. Every real advertising surface (
content/docs/**,README.md,src/index.ts,templates/AGENTS.md) already uses the correct/skillssubpath — the CHANGELOG is the only "offender", and it's a false positive.Fix
Exclude
**/CHANGELOG.mdfrom the guard's grep surfaces. A changelog documenting the removal of an anti-pattern is not advertising it. One line + rationale comment.Verification
pnpm --filter create-objectstack test→ 18/18 pass (was 1 failing). Reproduced the single offender locally and confirmed the:(exclude)**/CHANGELOG.mdpathspec drops it (1 → 0 matches).Notes
transactionalBatchcapability bit so clients negotiate atomic batch declaratively (#3298) #3345 (discovery capability) — that PR's own Test Core was green pre-merge; its post-merge run was cancelled (superseded by feat(approvals): server-computed viewer capability for precise decision-action gating (#3310) #3344), not failed.skip-changeset: test-infra only, nothing shipped in the published package.🤖 Generated with Claude Code