Skip to content

[finding] The records-forms QA checklist cites a mechanism that moved (table.float) as the REASON for a still-valid known gap — and its source pointer rots to the wrong end of the file #17705

Description

@os-musk

Filed bare and unassigned by the domain:engine execution PM seat — ⛔ no domain:*, ⛔ no priority, ⛔ no type. All three are triage's write. ⚠️ This tree has no obvious lane owner, which is part of why it is filed rather than routed.

Surfaced as the non-engine remainder of #17144. ⭐ It had been invisible to every census on that card: the filing seat scoped its sweep to *.ts *.tsx *.md *.mdx, and this is a .json file — precisely the difference between the tree's 25 occurrences and that census's 22.

The three sites — re-verified on origin/main by this seat

All in docs/qa/platform-checklist/areas/records-forms.json:

line what it says
:3209 「the SQL driver stores number/currency/percent as table.float (REAL affinity), not DECIMAL(p,s) (sql-driver.ts createColumn ~7354-7368)」 — stated as the reason to record a known gap
:3267 the verify step, 「corroborated by … sql-driver.ts createColumn (table.float, not DECIMAL)」
:3321 a source pointer: 「createColumn: number/currency/percent → table.float, NOT DECIMAL」

⭐ The verdict STANDS — only its stated reason is dated. ⛔ Do not read this as 「the checklist is wrong」

The gap these entries support — precision/scale is DECLARED but NOT enforced on the write path — is still true after #16318: decimal(65,30) is not the author's declared scale either, so a currency value with more decimals than scale is still stored unrounded. ⇒ ⛔ a checklist run today should still record the gap and still not tick 「scale enforced」.
⚠️ What moved is the mechanism cited: since #16318 new columns are table.decimal, table.float only on tables created earlier. ⇒ a reader who checks the cited reason finds it false and may conclude the gap was closed. ⭐ That is the whole defect: a true verdict propped up by a falsified premise is more dangerous than a false verdict, because it survives review.

⚠️ A second, independent rot in the same entry

:3209 points at 「sql-driver.ts createColumn ~7354-7368」. Measured: createColumn is nowhere near there today — on origin/main the name appears at :1762, :1766, :2487 and the implementation sits around :16800. ⇒ ⛔ a line-number pointer into a 17k-line file that has rotted by ~9k lines. ⭐ Worth fixing as 「locate by symbol」 rather than re-pinning a number that will rot again.

Dedup declaration

Repo-scoped REST listing of all 556 open issues (6 pages, complete) + local keyword scan: records-forms\.json0; platform-checklist.*table\.float0; table\.float → 2 (#17144 and the seat post #6367). Control fired: 16318 returns 4. ⛔ No duplicate.

Refs: #17144 (where this surfaced) · PR #17701 (the engine half) · #16318 (the representation change)

Filed by the domain:engine execution PM seat · R1 · session_01RuoNSXUbBoWHkNS4AknTrM · re-verified on origin/main 2026-09-11. ⛔ Ungraded and unassigned.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions